Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3883)

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Issue 2917873003: Ignore download bytes in page load metrics. (Closed)
Patch Set: address comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
diff --git a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc b/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
index a5bf8563dcf4a5e9c37d2aa7964c7903c4fde59c..5508120af11f8232424f66a1b367a1b760435014 100644
--- a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
+++ b/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
@@ -1111,6 +1111,33 @@ IN_PROC_BROWSER_TEST_P(PageLoadMetricsBrowserTest, PayloadSize) {
histogram_tester_.ExpectBucketCount(internal::kHistogramTotalBytes, 10, 1);
}
+IN_PROC_BROWSER_TEST_P(PageLoadMetricsBrowserTest,
+ PayloadSizeIgnoresDownloads) {
+ ASSERT_TRUE(embedded_test_server()->Start());
+
+ bool prev_io_allowed = base::ThreadRestrictions::SetIOAllowed(true);
+ {
+ base::ScopedTempDir downloads_directory;
+ ASSERT_TRUE(downloads_directory.CreateUniqueTempDir());
+ browser()->profile()->GetPrefs()->SetFilePath(
+ prefs::kDownloadDefaultDirectory, downloads_directory.GetPath());
+ content::DownloadTestObserverTerminal downloads_observer(
+ content::BrowserContext::GetDownloadManager(browser()->profile()),
+ 1, // == wait_count (only waiting for "download-test1.lib").
+ content::DownloadTestObserver::ON_DANGEROUS_DOWNLOAD_FAIL);
+
+ ui_test_utils::NavigateToURL(
+ browser(), embedded_test_server()->GetURL(
+ "/page_load_metrics/download_anchor_click.html"));
+ downloads_observer.WaitForFinished();
+ }
+ base::ThreadRestrictions::SetIOAllowed(prev_io_allowed);
+
+ NavigateToUntrackedUrl();
+
+ histogram_tester_.ExpectUniqueSample(internal::kHistogramTotalBytes, 0, 1);
+}
+
INSTANTIATE_TEST_CASE_P(
/* no prefix */,
PageLoadMetricsBrowserTest,

Powered by Google App Engine
This is Rietveld 408576698