[CrOS Tether] Move the DeviceStatus normalizer code from HostScanner into its own file.

[CrOS Tether] Move the DeviceStatus normalizer code from HostScanner into its own file.

This is in preparation for normalizing DeviceStatus updates received as part of the KeepAliveTickle flow.

BUG=672263
Review-Url: https://codereview.chromium.org/2917813002
Cr-Commit-Position: refs/heads/master@{#476412}
Committed: https://chromium.googlesource.com/chromium/src/+/6b89a30a734c41441fefb7f9e6d94de673a90a01

[Kyle Horimoto, 2017-05-31 23:13:15]

khorimoto@chromium.org changed reviewers:
+ hansberry@chromium.org

[Ryan Hansberry, 2017-06-01 01:14:25]

I don't feel strongly about this, but have you considered changing HostScanCache
to accept only a DeviceStatus, and making it responsible for this normalization
process?

[Kyle Horimoto, 2017-06-01 18:21:39]

On 2017/06/01 01:14:25, Ryan Hansberry wrote:
> I don't feel strongly about this, but have you considered changing
HostScanCache
> to accept only a DeviceStatus, and making it responsible for this
normalization
> process?

I did consider that, but I prefer this approach because it makes HostScanCache
completely independent of the protocol used to communicate with Android hosts.
Additionally, it makes the class easier to reason about: you pass in properties,
and you expect the cache to contain those properties. If we passed in a
DeviceState object directly, you'd pass in an object and would expect different
properties to be contained in the cache.

[Ryan Hansberry, 2017-06-01 18:51:22]

The CQ bit was checked by hansberry@chromium.org

[Ryan Hansberry, 2017-06-01 18:51:23]

lgtm

[commit-bot: I haz the power, 2017-06-01 18:52:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 20:27:56]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496343082805760,
"parent_rev": "3e6bc59e946bac1b9829d21df6d03481718f12fd", "commit_rev":
"6b89a30a734c41441fefb7f9e6d94de673a90a01"}

[commit-bot: I haz the power, 2017-06-01 20:28:04]

Description was changed from

==========
[CrOS Tether] Move the DeviceStatus normalizer code from HostScanner into its
own file.

This is in preparation for normalizing DeviceStatus updates received as part of
the KeepAliveTickle flow.

BUG=672263
==========

to

==========
[CrOS Tether] Move the DeviceStatus normalizer code from HostScanner into its
own file.

This is in preparation for normalizing DeviceStatus updates received as part of
the KeepAliveTickle flow.

BUG=672263

Review-Url: https://codereview.chromium.org/2917813002
Cr-Commit-Position: refs/heads/master@{#476412}
Committed:
https://chromium.googlesource.com/chromium/src/+/6b89a30a734c41441fefb7f9e6d9...
==========

[commit-bot: I haz the power, 2017-06-01 20:28:06]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6b89a30a734c41441fefb7f9e6d9...