Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Issue 2913363002: [CrOS Tether] Add KeepAliveTickleResponse messages to both the proto file and MessageWrapper. (Closed)

Created:
3 years, 6 months ago by Kyle Horimoto
Modified:
3 years, 6 months ago
Reviewers:
Ryan Hansberry
CC:
chromium-reviews, jlklein+watch-tether_chromium.org, tengs+watch-tether_chromium.org, hansberry+watch-tether_chromium.org, jhawkins+watch-tether_chromium.org, oshima+watch_chromium.org, lesliewatkins+watch-tether_chromium.org, khorimoto+watch-tether_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[CrOS Tether] Add KeepAliveTickleResponse messages to both the proto file and MessageWrapper. BUG=672263 Review-Url: https://codereview.chromium.org/2913363002 Cr-Commit-Position: refs/heads/master@{#476438} Committed: https://chromium.googlesource.com/chromium/src/+/f7205025f30cf791d77cb10c92cf1eb63082ee36

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M chromeos/components/tether/message_wrapper.h View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/components/tether/message_wrapper.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M chromeos/components/tether/message_wrapper_unittest.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chromeos/components/tether/proto/tether.proto View 2 chunks +6 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
Kyle Horimoto
3 years, 6 months ago (2017-06-01 00:35:57 UTC) #2
Ryan Hansberry
lgtm
3 years, 6 months ago (2017-06-01 01:15:54 UTC) #4
commit-bot: I haz the power
This CL has an open dependency (Issue 2917813002 Patch 20001). Please resolve the dependency and ...
3 years, 6 months ago (2017-06-01 01:16:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2913363002/40001
3 years, 6 months ago (2017-06-01 20:33:31 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 21:15:15 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f7205025f30cf791d77cb10c92cf...

Powered by Google App Engine
This is Rietveld 408576698