Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2917753002: Use early-return when BidirectionalStreamQuicImpl calls NotifyError. (Closed)

Created:
3 years, 6 months ago by Ryan Hamilton
Modified:
3 years, 6 months ago
Reviewers:
xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use early-return when BidirectionalStreamQuicImpl calls NotifyError. Review-Url: https://codereview.chromium.org/2917753002 Cr-Commit-Position: refs/heads/master@{#476118} Committed: https://chromium.googlesource.com/chromium/src/+/9128b3b44a3141a7c67161e53b35d511e91aa282

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
M net/quic/chromium/bidirectional_stream_quic_impl.cc View 1 chunk +15 lines, -13 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
Ryan Hamilton
Just a minor cleanup to use early-return when we hit an error which reduces a ...
3 years, 6 months ago (2017-05-31 20:56:36 UTC) #2
xunjieli
LGTM. Thanks for the cleanup!
3 years, 6 months ago (2017-05-31 21:02:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2917753002/1
3 years, 6 months ago (2017-06-01 00:47:19 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 00:54:42 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9128b3b44a3141a7c67161e53b35...

Powered by Google App Engine
This is Rietveld 408576698