Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2914073002: Avoid crashing when a BidirectionalStreamQuicImpl is deleted during OnStreamReady. (Closed)

Created:
3 years, 6 months ago by Ryan Hamilton
Modified:
3 years, 6 months ago
Reviewers:
xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid crashing when a BidirectionalStreamQuicImpl is deleted during OnStreamReady. BUG=728310 Review-Url: https://codereview.chromium.org/2914073002 Cr-Commit-Position: refs/heads/master@{#476088} Committed: https://chromium.googlesource.com/chromium/src/+/92555328de0f8ad2579d0daab74c2045497de3c3

Patch Set 1 #

Total comments: 2

Patch Set 2 : newline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -13 lines) Patch
M net/quic/chromium/bidirectional_stream_quic_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/chromium/bidirectional_stream_quic_impl.cc View 4 chunks +22 lines, -8 lines 0 comments Download
M net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc View 1 5 chunks +80 lines, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (9 generated)
Ryan Hamilton
3 years, 6 months ago (2017-05-31 20:05:53 UTC) #2
xunjieli
Thanks for the fix! https://codereview.chromium.org/2914073002/diff/1/net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc File net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc (right): https://codereview.chromium.org/2914073002/diff/1/net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc#newcode1655 net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc:1655: } nit: could use a ...
3 years, 6 months ago (2017-05-31 20:17:42 UTC) #3
Ryan Hamilton
Thanks https://codereview.chromium.org/2914073002/diff/1/net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc File net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc (right): https://codereview.chromium.org/2914073002/diff/1/net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc#newcode1655 net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc:1655: } On 2017/05/31 20:17:42, xunjieli (Slow.until.6-5) wrote: > ...
3 years, 6 months ago (2017-05-31 20:30:36 UTC) #4
xunjieli
Sorry, I thought i l-g-t-med. LGTM
3 years, 6 months ago (2017-05-31 20:48:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2914073002/20001
3 years, 6 months ago (2017-05-31 23:04:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2914073002/20001
3 years, 6 months ago (2017-05-31 23:17:35 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 23:23:11 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/92555328de0f8ad2579d0daab74c...

Powered by Google App Engine
This is Rietveld 408576698