Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2917543002:
[WebAPK] Add more GooglePlayInstallResults to track install failure pt 1/2 (Closed)
Description[WebAPK] Add more GooglePlayInstallResults to track install failure.
This CL adds new GooglePlayInstallResults to better determine the install
failure reason when IPlayInstallService#installPackage() fails immediately
BUG=727893
Review-Url: https://codereview.chromium.org/2906363002
Cr-Original-Commit-Position: refs/heads/master@{#475537}
Review-Url: https://codereview.chromium.org/2917543002
Cr-Commit-Position: refs/heads/master@{#476276}
Committed: https://chromium.googlesource.com/chromium/src/+/dd5ab01de0ae0dbb0a56e0342ee484ac1ebb7a94
Patch Set 1 #
Messages
Total messages: 25 (15 generated)
Description was changed from ========== [WebAPK] Add more GooglePlayInstallResults to track install failure. This CL adds new GooglePlayInstallResults to better determine the install failure reason when IPlayInstallService#installPackage() fails immediately BUG=718475 Review-Url: https://codereview.chromium.org/2906363002 Cr-Commit-Position: refs/heads/master@{#475537} ========== to ========== [WebAPK] Add more GooglePlayInstallResults to track install failure. This CL adds new GooglePlayInstallResults to better determine the install failure reason when IPlayInstallService#installPackage() fails immediately BUG=718475 Review-Url: https://codereview.chromium.org/2906363002 Cr-Commit-Position: refs/heads/master@{#475537} ==========
pkotwicz@chromium.org changed reviewers: + hanxi@chromium.org
Xi, can you please take a look?
lgtm
pkotwicz@chromium.org changed reviewers: + isherman@chromium.org
isherman@ for tools/metrics/histograms/enums.xml
On 2017/05/31 18:12:33, pkotwicz wrote: > isherman@ for tools/metrics/histograms/enums.xml You don't need my review for straightforward additions to enums.xml =)
The CQ bit was checked by isherman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by pkotwicz@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
pkotwicz@chromium.org changed reviewers: + yfriedman@chromium.org
Yaron for OWNERS
The CQ bit was checked by yfriedman@chromium.org
lgtm
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1496326126724970, "parent_rev":
"aa5ed397afd557d82d067bf9ec5652ed5fef1d10", "commit_rev":
"dd5ab01de0ae0dbb0a56e0342ee484ac1ebb7a94"}
Message was sent while issue was closed.
Description was changed from ========== [WebAPK] Add more GooglePlayInstallResults to track install failure. This CL adds new GooglePlayInstallResults to better determine the install failure reason when IPlayInstallService#installPackage() fails immediately BUG=718475 Review-Url: https://codereview.chromium.org/2906363002 Cr-Commit-Position: refs/heads/master@{#475537} ========== to ========== [WebAPK] Add more GooglePlayInstallResults to track install failure. This CL adds new GooglePlayInstallResults to better determine the install failure reason when IPlayInstallService#installPackage() fails immediately BUG=718475 Review-Url: https://codereview.chromium.org/2906363002 Cr-Original-Commit-Position: refs/heads/master@{#475537} Review-Url: https://codereview.chromium.org/2917543002 Cr-Commit-Position: refs/heads/master@{#476276} Committed: https://chromium.googlesource.com/chromium/src/+/dd5ab01de0ae0dbb0a56e0342ee4... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/dd5ab01de0ae0dbb0a56e0342ee4...
Message was sent while issue was closed.
Description was changed from ========== [WebAPK] Add more GooglePlayInstallResults to track install failure. This CL adds new GooglePlayInstallResults to better determine the install failure reason when IPlayInstallService#installPackage() fails immediately BUG=718475 Review-Url: https://codereview.chromium.org/2906363002 Cr-Original-Commit-Position: refs/heads/master@{#475537} Review-Url: https://codereview.chromium.org/2917543002 Cr-Commit-Position: refs/heads/master@{#476276} Committed: https://chromium.googlesource.com/chromium/src/+/dd5ab01de0ae0dbb0a56e0342ee4... ========== to ========== [WebAPK] Add more GooglePlayInstallResults to track install failure. This CL adds new GooglePlayInstallResults to better determine the install failure reason when IPlayInstallService#installPackage() fails immediately BUG=727893 Review-Url: https://codereview.chromium.org/2906363002 Cr-Original-Commit-Position: refs/heads/master@{#475537} Review-Url: https://codereview.chromium.org/2917543002 Cr-Commit-Position: refs/heads/master@{#476276} Committed: https://chromium.googlesource.com/chromium/src/+/dd5ab01de0ae0dbb0a56e0342ee4... ==========
Message was sent while issue was closed.
Patchset #2 (id:20001) has been deleted |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
