Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 2906363002: Use fallback mechanism to obtain connected WiFi information in pre-M devices when Location permissi… (Closed)

Created:
3 years, 6 months ago by lbargu
Modified:
3 years, 6 months ago
Reviewers:
Ted C
CC:
chromium-reviews, jdonnelly+watch_chromium.org, agrieve+watch_chromium.org, search-device-location_google.com, dougt
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use fallback mechanism to obtain connected WiFi information in pre-M devices when Location permissions are granted. When location permission is not granted, nothing should change and we won't attempt to get connected wifi info. This is required because the manifest is only including the ACCESS_WIFI_STATE permission in M+ devices. BUG=718475 Review-Url: https://codereview.chromium.org/2906363002 Cr-Commit-Position: refs/heads/master@{#475537} Committed: https://chromium.googlesource.com/chromium/src/+/ed9717b82b77fe10d3c84cc59100115384879fca

Patch Set 1 #

Patch Set 2 : Use fallback mechanism to obtain connected WiFi information in pre-M devices when Location permissi… #

Patch Set 3 : Use fallback mechanism to obtain connected WiFi information in pre-M devices when Location permissi… #

Patch Set 4 : Use fallback mechanism to obtain connected WiFi information in pre-M devices when Location permissi… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -6 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/PlatformNetworksManager.java View 2 chunks +23 lines, -3 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/omnibox/geo/PlatformNetworksManagerTest.java View 1 2 7 chunks +40 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
lbargu
3 years, 6 months ago (2017-05-29 15:20:41 UTC) #3
Ted C
lgtm
3 years, 6 months ago (2017-05-30 14:51:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2906363002/60001
3 years, 6 months ago (2017-05-30 14:54:54 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 15:33:48 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/ed9717b82b77fe10d3c84cc59100...

Powered by Google App Engine
This is Rietveld 408576698