DescriptionRevert of chromeos: Remove SystemTrayDelegate::GetIMEManagedMessage() (patchset #6 id:100001 of https://codereview.chromium.org/2911303003/ )
Reason for revert:
I'm going to take a different approach to the IME methods in the system tray delegate. There's a design doc linked from the bug.
Original issue's description:
> chromeos: Remove SystemTrayDelegate::GetIMEManagedMessage()
>
> For the mustash project we're eliminating ash-to-chrome delegates because
> ash will run in its own process.
>
> Instead of delegating back to chrome to look up a string, do the lookup
> directly in ash.
>
> Collapse the string with an existing page info string with almost-identical
> text. This saves a little binary size and allows the string to be used in
> both chromeos ash code and non-chromeos extensions webui code in chrome.
>
> BUG=724305
> TEST=ash_unittests, manual tests of IME menus
>
> Review-Url: https://codereview.chromium.org/2911303003
> Cr-Commit-Position: refs/heads/master@{#476314}
> Committed: https://chromium.googlesource.com/chromium/src/+/800af5e6c1c96ce81b21cc615cad3aa76d250136
TBR=msw@chromium.org,pastarmovj@chromium.org,blundell@chromium.org,stevenjb@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=724305
Review-Url: https://codereview.chromium.org/2917423002
Cr-Commit-Position: refs/heads/master@{#477010}
Committed: https://chromium.googlesource.com/chromium/src/+/bcdc288b89a5645109f8a743fd65446aa0cf2ce6
Patch Set 1 #Messages
Total messages: 6 (3 generated)
|