Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 2917423002: Revert of chromeos: Remove SystemTrayDelegate::GetIMEManagedMessage() (Closed)

Created:
3 years, 6 months ago by James Cook
Modified:
3 years, 6 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, sadrul, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, oshima+watch_chromium.org, lhchavez+watch_chromium.org, victorhsieh+watch_chromium.org, kalyank, srahim+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of chromeos: Remove SystemTrayDelegate::GetIMEManagedMessage() (patchset #6 id:100001 of https://codereview.chromium.org/2911303003/ ) Reason for revert: I'm going to take a different approach to the IME methods in the system tray delegate. There's a design doc linked from the bug. Original issue's description: > chromeos: Remove SystemTrayDelegate::GetIMEManagedMessage() > > For the mustash project we're eliminating ash-to-chrome delegates because > ash will run in its own process. > > Instead of delegating back to chrome to look up a string, do the lookup > directly in ash. > > Collapse the string with an existing page info string with almost-identical > text. This saves a little binary size and allows the string to be used in > both chromeos ash code and non-chromeos extensions webui code in chrome. > > BUG=724305 > TEST=ash_unittests, manual tests of IME menus > > Review-Url: https://codereview.chromium.org/2911303003 > Cr-Commit-Position: refs/heads/master@{#476314} > Committed: https://chromium.googlesource.com/chromium/src/+/800af5e6c1c96ce81b21cc615cad3aa76d250136 TBR=msw@chromium.org,pastarmovj@chromium.org,blundell@chromium.org,stevenjb@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=724305 Review-Url: https://codereview.chromium.org/2917423002 Cr-Commit-Position: refs/heads/master@{#477010} Committed: https://chromium.googlesource.com/chromium/src/+/bcdc288b89a5645109f8a743fd65446aa0cf2ce6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -63 lines) Patch
M ash/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ash/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M ash/strings/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M ash/system/ime/tray_ime_chromeos.cc View 3 chunks +1 line, -9 lines 0 comments Download
M ash/system/ime_menu/ime_menu_tray_unittest.cc View 3 chunks +12 lines, -44 lines 0 comments Download
M ash/system/tray/system_tray_delegate.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/system/tray/system_tray_delegate.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_support_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/options/network_config_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 3 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/policy_indicator_localized_strings_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/policy_strings.grdp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
James Cook
Created Revert of chromeos: Remove SystemTrayDelegate::GetIMEManagedMessage()
3 years, 6 months ago (2017-06-05 15:40:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2917423002/1
3 years, 6 months ago (2017-06-05 15:41:36 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-05 17:27:26 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bcdc288b89a5645109f8a743fd65...

Powered by Google App Engine
This is Rietveld 408576698