chromeos: Remove SystemTrayDelegate::GetIMEManagedMessage()

chromeos: Remove SystemTrayDelegate::GetIMEManagedMessage()

For the mustash project we're eliminating ash-to-chrome delegates because
ash will run in its own process.

Instead of delegating back to chrome to look up a string, do the lookup
directly in ash.

Collapse the string with an existing page info string with almost-identical
text. This saves a little binary size and allows the string to be used in
both chromeos ash code and non-chromeos extensions webui code in chrome.

BUG=724305
TEST=ash_unittests, manual tests of IME menus

Review-Url: https://codereview.chromium.org/2911303003
Cr-Commit-Position: refs/heads/master@{#476314}
Committed: https://chromium.googlesource.com/chromium/src/+/800af5e6c1c96ce81b21cc615cad3aa76d250136

[James Cook, 2017-05-30 21:00:28]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2017-05-30 21:00:29]

msw, please take a look.

[msw, 2017-05-30 22:17:07]

You should definitely ping components/policy/OWNERS about the new home for the
string; otherwise lgtm.

[James Cook, 2017-05-30 22:48:32]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 22:49:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2017-05-30 22:53:08]

jamescook@chromium.org changed reviewers:
+ pastarmovj@chromium.org

[James Cook, 2017-05-30 22:53:09]

pastarmovj, can you take a look as a components/policy owner? I moved a string
from chrome strings to policy strings because the string is used in both
chromeos ash code and in non-chromeos extensions webui chrome code.

[commit-bot: I haz the power, 2017-05-31 00:25:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 00:25:56]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pastarmovj, 2017-05-31 08:45:26]

There is more or less the same string already defined as
IDS_PAGE_INFO_PERMISSION_ASK_BY_POLICY here
https://cs.chromium.org/chromium/src/components/page_info_strings.grdp?rcl=03...

Is there a way to leave only one of those two in order to avoid increasing the
size of the binary?

[James Cook, 2017-05-31 14:36:28]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 14:36:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2017-05-31 15:20:55]

Description was changed from

==========
chromeos: Remove SystemTrayDelegate::GetIMEManagedMessage()

For the mustash project we're eliminating ash-to-chrome delegates because
ash will run in its own process.

Instead of delegating back to chrome to look up a string, do the lookup
directly in ash.

Move the string into components/policy strings instead of ash strings
because the string is also used in non-chromeos extensions webui code in
chrome.

BUG=724305
TEST=ash_unittests, manual tests of IME menus
==========

to

==========
chromeos: Remove SystemTrayDelegate::GetIMEManagedMessage()

For the mustash project we're eliminating ash-to-chrome delegates because
ash will run in its own process.

Instead of delegating back to chrome to look up a string, do the lookup
directly in ash.

Collapse the string with an existing page info string with almost-identical
text. This saves a little binary size and allows the string to be used in
both chromeos ash code and non-chromeos extensions webui code in chrome.

BUG=724305
TEST=ash_unittests, manual tests of IME menus
==========

[James Cook, 2017-05-31 15:21:57]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 15:22:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2017-05-31 15:22:55]

pastarmovj, please take another look. The previous version of the CL didn't
increase the size of strings (it moved the string, not copied), but this version
decreases our size a little.

[James Cook, 2017-05-31 15:40:23]

On 2017/05/31 15:22:55, James Cook wrote:
> pastarmovj, please take another look. The previous version of the CL didn't
> increase the size of strings (it moved the string, not copied), but this
version
> decreases our size a little.

Hmm, on further thought I would prefer not to collapse the strings. They are not
quite the same -- the one from generated_resources.grd ends with a period and is
consistent with other tooltip strings in settings. The one from page info does
not end in a period, is shorter, and is consistent with other page info strings.

I'd prefer to stick with patch set 2 (and fix the test). WDYT?

[pastarmovj, 2017-05-31 16:34:42]

LGTM. Thanks!

[James Cook, 2017-05-31 17:03:10]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 17:03:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2017-05-31 17:04:25]

jamescook@chromium.org changed reviewers:
+ blundell@chromium.org, stevenjb@chromium.org

[James Cook, 2017-05-31 17:04:25]

stevenjb, can I get owners approval for chrome/browser/chromeos?

blundell, can I get owners approval for adding a dep on components/strings?

[stevenjb, 2017-05-31 18:51:49]

c/b/chromeos lgtm

[commit-bot: I haz the power, 2017-05-31 20:32:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 20:32:18]

Dry run: This issue passed the CQ dry run.

[blundell, 2017-06-01 11:27:22]

DEPS on //components/strings lgtm

[James Cook, 2017-06-01 14:37:20]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2017-06-01 14:37:21]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org,
pastarmovj@chromium.org, stevenjb@chromium.org, blundell@chromium.org
Link to the patchset: https://codereview.chromium.org/2911303003/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2017-06-01 14:37:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 16:09:11]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1496327840241420,
"parent_rev": "46c85c0e2c60c88ed671ea707bebd3d35bc4f28b", "commit_rev":
"800af5e6c1c96ce81b21cc615cad3aa76d250136"}

[commit-bot: I haz the power, 2017-06-01 16:09:30]

Description was changed from

==========
chromeos: Remove SystemTrayDelegate::GetIMEManagedMessage()

For the mustash project we're eliminating ash-to-chrome delegates because
ash will run in its own process.

Instead of delegating back to chrome to look up a string, do the lookup
directly in ash.

Collapse the string with an existing page info string with almost-identical
text. This saves a little binary size and allows the string to be used in
both chromeos ash code and non-chromeos extensions webui code in chrome.

BUG=724305
TEST=ash_unittests, manual tests of IME menus
==========

to

==========
chromeos: Remove SystemTrayDelegate::GetIMEManagedMessage()

For the mustash project we're eliminating ash-to-chrome delegates because
ash will run in its own process.

Instead of delegating back to chrome to look up a string, do the lookup
directly in ash.

Collapse the string with an existing page info string with almost-identical
text. This saves a little binary size and allows the string to be used in
both chromeos ash code and non-chromeos extensions webui code in chrome.

BUG=724305
TEST=ash_unittests, manual tests of IME menus

Review-Url: https://codereview.chromium.org/2911303003
Cr-Commit-Position: refs/heads/master@{#476314}
Committed:
https://chromium.googlesource.com/chromium/src/+/800af5e6c1c96ce81b21cc615cad...
==========

[commit-bot: I haz the power, 2017-06-01 16:09:32]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/800af5e6c1c96ce81b21cc615cad...

[James Cook, 2017-06-05 15:40:01]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/2917423002/ by jamescook@chromium.org.

The reason for reverting is: I'm going to take a different approach to the IME
methods in the system tray delegate. There's a design doc linked from the bug.
.