Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2917363002: Automatically fire AX events on Mac based on tree changes (Closed)

Created:
3 years, 6 months ago by dmazzoni
Modified:
3 years, 6 months ago
Reviewers:
nektarios
CC:
aboxhall+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dougt+watch_chromium.org, dtseng+watch_chromium.org, extensions-reviews_chromium.org, jam, je_julie, mac-reviews_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Automatically fire AX events on Mac based on tree changes This change uses tree changes to automatically determine which Mac AX events to fire, rather than getting the events directly from Blink. The code to fire events from Blink is removed for OS_MACOSX in this change. Subsequent changes will do the same for Windows, Linux, Android, and Chrome OS, and then we can delete all of the code that fires specific events from Blink, and just mark AX nodes as dirty instead. BUG=699438 Review-Url: https://codereview.chromium.org/2917363002 Cr-Commit-Position: refs/heads/master@{#477889} Committed: https://chromium.googlesource.com/chromium/src/+/5e3acae98e5b9417f6757866a264284c9e38c809

Patch Set 1 #

Patch Set 2 : Fix some other subclassers of AXTreeDelegate #

Patch Set 3 : Fix accidental shadowing of BrowserAccessibilityManager::OnAtomicUpdateFinished, caught by browser … #

Unified diffs Side-by-side diffs Delta from patch set Stats (+284 lines, -32 lines) Patch
M chrome/renderer/extensions/automation_internal_custom_bindings.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/renderer/extensions/automation_internal_custom_bindings.cc View 1 chunk +4 lines, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_manager.h View 2 chunks +7 lines, -4 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager.cc View 1 2 4 chunks +34 lines, -12 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_mac.h View 1 chunk +25 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_mac.mm View 1 2 2 chunks +168 lines, -0 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_events_browsertest.cc View 2 1 chunk +5 lines, -0 lines 0 comments Download
A content/test/data/accessibility/event/add-alert-expected-mac.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M content/test/data/accessibility/event/aria-combo-box-expand-expected-mac.txt View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/event/aria-combo-box-focus-expected-mac.txt View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/event/aria-treeitem-focus-expected-mac.txt View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/event/listbox-next-expected-mac.txt View 1 chunk +0 lines, -2 lines 0 comments Download
A content/test/data/accessibility/event/live-region-add-live-attribute.html View 1 chunk +12 lines, -0 lines 0 comments Download
A content/test/data/accessibility/event/live-region-add-live-attribute-expected-mac.txt View 1 chunk +1 line, -0 lines 0 comments Download
M content/test/data/accessibility/event/menulist-collapse-expected-mac.txt View 1 chunk +1 line, -0 lines 0 comments Download
M ui/accessibility/ax_tree.h View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/accessibility/ax_tree.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M ui/accessibility/ax_tree_fuzzer.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M ui/accessibility/ax_tree_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/accessibility/platform/test_ax_node_wrapper.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 22 (14 generated)
dmazzoni
3 years, 6 months ago (2017-06-05 06:25:17 UTC) #3
nektarios
lgtm
3 years, 6 months ago (2017-06-06 21:58:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2917363002/20001
3 years, 6 months ago (2017-06-07 17:48:14 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/472109)
3 years, 6 months ago (2017-06-07 19:53:24 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2917363002/40001
3 years, 6 months ago (2017-06-07 20:34:21 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/429023) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, ...
3 years, 6 months ago (2017-06-07 21:14:49 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2917363002/40001
3 years, 6 months ago (2017-06-08 03:50:30 UTC) #19
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 04:40:08 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5e3acae98e5b9417f6757866a264...

Powered by Google App Engine
This is Rietveld 408576698