chrome/renderer/extensions/automation_internal_custom_bindings.cc - Issue 2917363002: Automatically fire AX events on Mac based on tree changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/automation_internal_custom_bindings.cc

Issue 2917363002: Automatically fire AX events on Mac based on tree changes (Closed)

Patch Set: Fix accidental shadowing of BrowserAccessibilityManager::OnAtomicUpdateFinished, caught by browser … Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/extensions/automation_internal_custom_bindings.cc

diff --git a/chrome/renderer/extensions/automation_internal_custom_bindings.cc b/chrome/renderer/extensions/automation_internal_custom_bindings.cc

index 89a19c6ad1a9dfdf49704029ccbc007b7d4b76c6..9f629dea7457e6d7d23b6f3d388acff05b04d832 100644

--- a/chrome/renderer/extensions/automation_internal_custom_bindings.cc

+++ b/chrome/renderer/extensions/automation_internal_custom_bindings.cc

@@ -1242,7 +1242,10 @@ void AutomationInternalCustomBindings::OnNodeDataWillChange(

text_changed_node_ids_.push_back(new_node_data.id);

}

-void AutomationInternalCustomBindings::OnTreeDataChanged(ui::AXTree* tree) {}

+void AutomationInternalCustomBindings::OnTreeDataChanged(

+ ui::AXTree* tree,

+ const ui::AXTreeData& old_tree_data,

+ const ui::AXTreeData& new_tree_data) {}

void AutomationInternalCustomBindings::OnNodeWillBeDeleted(ui::AXTree* tree,

ui::AXNode* node) {