Move LoadHTMLString method from WebFrame to WebLocalFrame.

Move LoadHTMLString method from WebFrame to WebLocalFrame.

Most callers were already calling through WebLocalFrame (tests had to be
changed to use MainFrameImpl accessor to realize that).  One test caller
(ParameterizedWebFrameTest.GetContentAsPlainText) cannot guarantee at
compile time that it has a local frame, but in practice the new
ToWebLocalFrame() passes all tests.

No intended behavior change.

BUG=416660
Review-Url: https://codereview.chromium.org/2917343004
Cr-Commit-Position: refs/heads/master@{#477381}
Committed: https://chromium.googlesource.com/chromium/src/+/bb1cff19414a4a999dc667baae35dd37ed9d545c

[Łukasz Anforowicz, 2017-06-05 23:16:15]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-05 23:16:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 03:29:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 03:29:53]

Dry run: This issue passed the CQ dry run.

[Łukasz Anforowicz, 2017-06-06 18:25:28]

Description was changed from

==========
Move LoadHTMLString method from WebFrame to WebLocalFrame.

All callers already were calling through WebLocalFrame
(although in one test the CL had to add a ToWebLocalFrame() call).

No intended behavior change.

BUG=416660
==========

to

==========
Move LoadHTMLString method from WebFrame to WebLocalFrame.

Most callers were already calling through WebLocalFrame (tests had to be
changed to use MainFrameImpl accessor to realize that).  One test caller
(ParameterizedWebFrameTest.GetContentAsPlainText) cannot guarantee at
compile time that it has a local frame, bit in practice the new
ToWebLocalFrame() passes all tests.

No intended behavior change.

BUG=416660
==========

[Łukasz Anforowicz, 2017-06-06 18:25:43]

lukasza@chromium.org changed reviewers:
+ dcheng@chromium.org

[Łukasz Anforowicz, 2017-06-06 18:25:44]

dcheng@, can you PTAL?

https://codereview.chromium.org/2917343004/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/tests/WebFrameTest.cpp (right):

https://codereview.chromium.org/2917343004/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/tests/WebFrameTest.cpp:4804: WebLocalFrame*
subframe = frame->FirstChild()->ToWebLocalFrame();
This seems safe in practice.

[dcheng, 2017-06-06 19:49:49]

lgtm

https://codereview.chromium.org/2917343004/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/tests/WebFrameTest.cpp (right):

https://codereview.chromium.org/2917343004/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/tests/WebFrameTest.cpp:4804: WebLocalFrame*
subframe = frame->FirstChild()->ToWebLocalFrame();
On 2017/06/06 18:25:44, Łukasz A. wrote:
> This seems safe in practice.

Acknowledged. Long-term, I'm hoping some sort of local root iterator will make
this reasonably easy to do.

[Łukasz Anforowicz, 2017-06-06 19:53:07]

Description was changed from

==========
Move LoadHTMLString method from WebFrame to WebLocalFrame.

Most callers were already calling through WebLocalFrame (tests had to be
changed to use MainFrameImpl accessor to realize that).  One test caller
(ParameterizedWebFrameTest.GetContentAsPlainText) cannot guarantee at
compile time that it has a local frame, bit in practice the new
ToWebLocalFrame() passes all tests.

No intended behavior change.

BUG=416660
==========

to

==========
Move LoadHTMLString method from WebFrame to WebLocalFrame.

Most callers were already calling through WebLocalFrame (tests had to be
changed to use MainFrameImpl accessor to realize that).  One test caller
(ParameterizedWebFrameTest.GetContentAsPlainText) cannot guarantee at
compile time that it has a local frame, but in practice the new
ToWebLocalFrame() passes all tests.

No intended behavior change.

BUG=416660
==========

[Łukasz Anforowicz, 2017-06-06 19:53:15]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2017-06-06 19:53:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 19:58:35]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496778795328850, "parent_rev":
"2e48d743c9c647a66409c98ba96cbe80fd70774b", "commit_rev":
"bb1cff19414a4a999dc667baae35dd37ed9d545c"}

[commit-bot: I haz the power, 2017-06-06 19:58:43]

Description was changed from

==========
Move LoadHTMLString method from WebFrame to WebLocalFrame.

Most callers were already calling through WebLocalFrame (tests had to be
changed to use MainFrameImpl accessor to realize that).  One test caller
(ParameterizedWebFrameTest.GetContentAsPlainText) cannot guarantee at
compile time that it has a local frame, but in practice the new
ToWebLocalFrame() passes all tests.

No intended behavior change.

BUG=416660
==========

to

==========
Move LoadHTMLString method from WebFrame to WebLocalFrame.

Most callers were already calling through WebLocalFrame (tests had to be
changed to use MainFrameImpl accessor to realize that).  One test caller
(ParameterizedWebFrameTest.GetContentAsPlainText) cannot guarantee at
compile time that it has a local frame, but in practice the new
ToWebLocalFrame() passes all tests.

No intended behavior change.

BUG=416660

Review-Url: https://codereview.chromium.org/2917343004
Cr-Commit-Position: refs/heads/master@{#477381}
Committed:
https://chromium.googlesource.com/chromium/src/+/bb1cff19414a4a999dc667baae35...
==========

[commit-bot: I haz the power, 2017-06-06 19:58:44]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bb1cff19414a4a999dc667baae35...