Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2917313003: Verify explicitly set names for memory benchmarks (Closed)

Created:
3 years, 6 months ago by ashleymarie1
Modified:
3 years, 6 months ago
Reviewers:
nednguyen, ulan, bashi, perezju
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Verify explicitly set names for memory benchmarks BUG=chromium:720002 Review-Url: https://codereview.chromium.org/2917313003 Cr-Commit-Position: refs/heads/master@{#477077} Committed: https://chromium.googlesource.com/chromium/src/+/bd6683a6e4ed433be7546f4629d1c0f564151b46

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M tools/perf/page_sets/blink_memory_mobile.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/page_sets/google_pages.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/page_sets/long_running_idle_google_cases.py View 2 chunks +4 lines, -2 lines 0 comments Download
M tools/perf/page_sets/memory_top_10_mobile.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
ashleymarie1
3 years, 6 months ago (2017-06-05 16:38:04 UTC) #3
nednguyen
lgtm
3 years, 6 months ago (2017-06-05 17:00:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2917313003/1
3 years, 6 months ago (2017-06-05 18:29:09 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/bd6683a6e4ed433be7546f4629d1c0f564151b46
3 years, 6 months ago (2017-06-05 20:44:35 UTC) #9
bashi
3 years, 6 months ago (2017-06-05 21:40:49 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698