Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Side by Side Diff: tools/perf/page_sets/blink_memory_mobile.py

Issue 2917313003: Verify explicitly set names for memory benchmarks (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/perf/page_sets/google_pages.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import logging 5 import logging
6 6
7 from telemetry.page import page as page_module 7 from telemetry.page import page as page_module
8 from telemetry.page import shared_page_state 8 from telemetry.page import shared_page_state
9 from telemetry import story 9 from telemetry import story
10 10
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 action_runner.WaitForJavaScriptCondition( 85 action_runner.WaitForJavaScriptCondition(
86 'document.querySelector("#apploadingdiv").style.opacity == "0"') 86 'document.querySelector("#apploadingdiv").style.opacity == "0"')
87 87
88 88
89 class BlinkMemoryMobilePageSet(story.StorySet): 89 class BlinkMemoryMobilePageSet(story.StorySet):
90 """Key mobile sites for Blink memory reduction.""" 90 """Key mobile sites for Blink memory reduction."""
91 91
92 def __init__(self): 92 def __init__(self):
93 super(BlinkMemoryMobilePageSet, self).__init__( 93 super(BlinkMemoryMobilePageSet, self).__init__(
94 archive_data_file='data/blink_memory_mobile.json', 94 archive_data_file='data/blink_memory_mobile.json',
95 cloud_storage_bucket=story.PARTNER_BUCKET) 95 cloud_storage_bucket=story.PARTNER_BUCKET,
96 verify_names=True)
96 97
97 # Why: High rate of Blink's memory consumption rate. 98 # Why: High rate of Blink's memory consumption rate.
98 self.AddStory(BlinkMemoryMobilePage( 99 self.AddStory(BlinkMemoryMobilePage(
99 'https://www.pinterest.com', 100 'https://www.pinterest.com',
100 page_set=self, 101 page_set=self,
101 name='Pinterest')) 102 name='Pinterest'))
102 self.AddStory(FacebookPage(self)) 103 self.AddStory(FacebookPage(self))
103 self.AddStory(TheVergePage(self)) 104 self.AddStory(TheVergePage(self))
104 105
105 # Why: High rate of Blink's memory comsumption rate on low-RAM devices. 106 # Why: High rate of Blink's memory comsumption rate on low-RAM devices.
(...skipping 19 matching lines...) Expand all
125 # Why: Key products. 126 # Why: Key products.
126 self.AddStory(GmailPage(page_set=self)) 127 self.AddStory(GmailPage(page_set=self))
127 self.AddStory(BlinkMemoryMobilePage( 128 self.AddStory(BlinkMemoryMobilePage(
128 'http://googlewebmastercentral.blogspot.com/2015/04/rolling-out-mobile-f riendly-update.html?m=1', 129 'http://googlewebmastercentral.blogspot.com/2015/04/rolling-out-mobile-f riendly-update.html?m=1',
129 page_set=self, 130 page_set=self,
130 name='Blogger')) 131 name='Blogger'))
131 self.AddStory(BlinkMemoryMobilePage( 132 self.AddStory(BlinkMemoryMobilePage(
132 'https://plus.google.com/app/basic/110031535020051778989/posts?source=ap ppromo', 133 'https://plus.google.com/app/basic/110031535020051778989/posts?source=ap ppromo',
133 page_set=self, 134 page_set=self,
134 name='GooglePlus')) 135 name='GooglePlus'))
OLDNEW
« no previous file with comments | « no previous file | tools/perf/page_sets/google_pages.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698