Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 2917063002: Revert of [heap] Decrease old space physical memory factor. (Closed)

Created:
3 years, 6 months ago by Michael Achenbach
Modified:
3 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Decrease old space physical memory factor. (patchset #3 id:40001 of https://codereview.chromium.org/2907363003/ ) Reason for revert: Fails on other bots now: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20debug/builds/16197 https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/13170 https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20gc%20stress/builds/6749 Original issue's description: > Fix tests regress-336820 and regress-678917. > > Execution tests regress-336820 and regress-678917 finished with error > messages "allocation failure GC in old space requested" and "fatal > javascript OOM in CALL_AND_RETRY_LAST". For successful execution, > parameter max_old_space_size must be increased and this is done inside > tests. > > TEST=mjsunit/regress/regress-336820, > mjsunit/regress/regress-678917 > BUG= > > Review-Url: https://codereview.chromium.org/2907363003 > Cr-Commit-Position: refs/heads/master@{#45672} > Committed: https://chromium.googlesource.com/v8/v8/+/1550c869094c5873da9226ae9b4de7084692a857 TBR=hpayer@chromium.org,jochen@chromium.org,mlippautz@chromium.org,mstarzinger@chromium.org,ulan@chromium.org,ivica.bogosavljevic@imgtec.com,bmeurer@chromium.org,jarin@chromium.org,ishell@chromium.org,Ilija.Pavlovic@imgtec.com,Ilija.Pavlovic@imgtec.com,Ilija.Pavlovic@imgtec.com,Ilija.Pavlovic@imgtec.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2917063002 Cr-Commit-Position: refs/heads/master@{#45673} Committed: https://chromium.googlesource.com/v8/v8/+/3b7ff7a5e53ad1a69c09304acf0434624b513f00

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M test/mjsunit/regress/regress-336820.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/regress/regress-678917.js View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of [heap] Decrease old space physical memory factor.
3 years, 6 months ago (2017-06-02 11:53:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2917063002/1
3 years, 6 months ago (2017-06-02 11:53:57 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 11:54:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/3b7ff7a5e53ad1a69c09304acf0434624b5...

Powered by Google App Engine
This is Rietveld 408576698