Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2907363003:
Fix tests regress-336820 and regress-678917. (Closed)
|
Created:
3 years, 6 months ago by Ilija.Pavlovic1 Modified:
3 years, 6 months ago Reviewers:
ivica.bogosavljevic, Igor Sheludko, ilija.pavlovic, jochen (gone - plz use gerrit), Michael Starzinger, Michael Lippautz, Jarin, Benedikt Meurer, Hannes Payer (out of office), ulan CC:
v8-reviews_googlegroups.com Target Ref:
refs/heads/master Project:
v8 Visibility:
Public. |
DescriptionFix tests regress-336820 and regress-678917.
Execution tests regress-336820 and regress-678917 finished with error
messages "allocation failure GC in old space requested" and "fatal
javascript OOM in CALL_AND_RETRY_LAST". For successful execution,
parameter max_old_space_size must be increased and this is done inside
tests.
TEST=mjsunit/regress/regress-336820,
mjsunit/regress/regress-678917
BUG=
Review-Url: https://codereview.chromium.org/2907363003
Cr-Original-Commit-Position: refs/heads/master@{#45672}
Committed: https://chromium.googlesource.com/v8/v8/+/1550c869094c5873da9226ae9b4de7084692a857
Review-Url: https://codereview.chromium.org/2907363003
Cr-Commit-Position: refs/heads/master@{#45681}
Committed: https://chromium.googlesource.com/v8/v8/+/9c8f0f09ea6d6c08eeaf80019dd41da17627ee03
Patch Set 1 #Patch Set 2 : Adapted tests. #Patch Set 3 : Increase max old space size for regress-336820.js. #Patch Set 4 : Increase max old space size for regress-678917.js. #Messages
Total messages: 36 (23 generated)
PTAL
On 2017/05/30 08:00:09, Ilija.Pavlovic1 wrote: > PTAL We cannot set this value to something lower than 4 because of performance tests.
On 2017/05/30 09:29:45, Hannes Payer wrote: > On 2017/05/30 08:00:09, Ilija.Pavlovic1 wrote: > > PTAL > > We cannot set this value to something lower than 4 because of performance tests. Any suggestions/ideas what should be maybe changed?
Description was changed from
==========
[heap] Decrease old space physical memory factor.
In ComputeMaxOldGenerationSize(), old_space_physical_memory_factor
was set on value 4 and this value caused error messages "allocation
failure GC in old space requested" and "fatal javascript OOM in
CALL_AND_RETRY_LAST" during execution tests regress-336820 and
regress-678917. When this factor is set on value 3, both tests will be
executed successfully.
TEST=mjsunit/regress/regress-336820,
mjsunit/regress/regress-678917
BUG=
==========
to
==========
Fix tests regress-336820 and regress-678917.
Execution tests regress-336820 and regress-678917 finished with error
messages "allocation failure GC in old space requested" and "fatal
javascript OOM in CALL_AND_RETRY_LAST". For successful execution,
parameter max_old_space_size must be increased and this is done inside
tests.
TEST=mjsunit/regress/regress-336820,
mjsunit/regress/regress-678917
BUG=
==========
ilija.pavlovic@imgtec.com changed reviewers: + bmeurer@chromium.org, ishell@chromium.org, jarin@chromium.org
PTAL
ping These changes are only in two lines so I would ask you to review it.
lgtm
The CQ bit was checked by ilija.pavlovic@imgtec.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...) v8_linux_arm64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng_trigg...)
The CQ bit was checked by ilija.pavlovic@imgtec.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by ilija.pavlovic@imgtec.com
The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org Link to the patchset: https://codereview.chromium.org/2907363003/#ps40001 (title: "Increase max old space size for regress-336820.js.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496396442998510,
"parent_rev": "502c6ae6a03979efbd3e006e6a0b8c3369ca2bbc", "commit_rev":
"1550c869094c5873da9226ae9b4de7084692a857"}
Message was sent while issue was closed.
Description was changed from
==========
Fix tests regress-336820 and regress-678917.
Execution tests regress-336820 and regress-678917 finished with error
messages "allocation failure GC in old space requested" and "fatal
javascript OOM in CALL_AND_RETRY_LAST". For successful execution,
parameter max_old_space_size must be increased and this is done inside
tests.
TEST=mjsunit/regress/regress-336820,
mjsunit/regress/regress-678917
BUG=
==========
to
==========
Fix tests regress-336820 and regress-678917.
Execution tests regress-336820 and regress-678917 finished with error
messages "allocation failure GC in old space requested" and "fatal
javascript OOM in CALL_AND_RETRY_LAST". For successful execution,
parameter max_old_space_size must be increased and this is done inside
tests.
TEST=mjsunit/regress/regress-336820,
mjsunit/regress/regress-678917
BUG=
Review-Url: https://codereview.chromium.org/2907363003
Cr-Commit-Position: refs/heads/master@{#45672}
Committed:
https://chromium.googlesource.com/v8/v8/+/1550c869094c5873da9226ae9b4de708469...
==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/v8/v8/+/1550c869094c5873da9226ae9b4de708469...
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2917063002/ by machenbach@chromium.org. The reason for reverting is: Fails on other bots now: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20debug/buil... https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20... https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%....
Message was sent while issue was closed.
Description was changed from
==========
Fix tests regress-336820 and regress-678917.
Execution tests regress-336820 and regress-678917 finished with error
messages "allocation failure GC in old space requested" and "fatal
javascript OOM in CALL_AND_RETRY_LAST". For successful execution,
parameter max_old_space_size must be increased and this is done inside
tests.
TEST=mjsunit/regress/regress-336820,
mjsunit/regress/regress-678917
BUG=
Review-Url: https://codereview.chromium.org/2907363003
Cr-Commit-Position: refs/heads/master@{#45672}
Committed:
https://chromium.googlesource.com/v8/v8/+/1550c869094c5873da9226ae9b4de708469...
==========
to
==========
Fix tests regress-336820 and regress-678917.
Execution tests regress-336820 and regress-678917 finished with error
messages "allocation failure GC in old space requested" and "fatal
javascript OOM in CALL_AND_RETRY_LAST". For successful execution,
parameter max_old_space_size must be increased and this is done inside
tests.
TEST=mjsunit/regress/regress-336820,
mjsunit/regress/regress-678917
BUG=
Review-Url: https://codereview.chromium.org/2907363003
Cr-Commit-Position: refs/heads/master@{#45672}
Committed:
https://chromium.googlesource.com/v8/v8/+/1550c869094c5873da9226ae9b4de708469...
==========
ilija.pavlovic@imgtec.com changed reviewers: + ilija.pavlovic@imgtec.com - Ilija.Pavlovic@imgtec.com
The CQ bit was checked by ilija.pavlovic@imgtec.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by ilija.pavlovic@imgtec.com
The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org Link to the patchset: https://codereview.chromium.org/2907363003/#ps60001 (title: "Increase max old space size for regress-678917.js.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1496408021863280,
"parent_rev": "bc1aef2610c655b34dd00257b973f4661c2b7283", "commit_rev":
"9c8f0f09ea6d6c08eeaf80019dd41da17627ee03"}
Message was sent while issue was closed.
Description was changed from
==========
Fix tests regress-336820 and regress-678917.
Execution tests regress-336820 and regress-678917 finished with error
messages "allocation failure GC in old space requested" and "fatal
javascript OOM in CALL_AND_RETRY_LAST". For successful execution,
parameter max_old_space_size must be increased and this is done inside
tests.
TEST=mjsunit/regress/regress-336820,
mjsunit/regress/regress-678917
BUG=
Review-Url: https://codereview.chromium.org/2907363003
Cr-Commit-Position: refs/heads/master@{#45672}
Committed:
https://chromium.googlesource.com/v8/v8/+/1550c869094c5873da9226ae9b4de708469...
==========
to
==========
Fix tests regress-336820 and regress-678917.
Execution tests regress-336820 and regress-678917 finished with error
messages "allocation failure GC in old space requested" and "fatal
javascript OOM in CALL_AND_RETRY_LAST". For successful execution,
parameter max_old_space_size must be increased and this is done inside
tests.
TEST=mjsunit/regress/regress-336820,
mjsunit/regress/regress-678917
BUG=
Review-Url: https://codereview.chromium.org/2907363003
Cr-Original-Commit-Position: refs/heads/master@{#45672}
Committed:
https://chromium.googlesource.com/v8/v8/+/1550c869094c5873da9226ae9b4de708469...
Review-Url: https://codereview.chromium.org/2907363003
Cr-Commit-Position: refs/heads/master@{#45681}
Committed:
https://chromium.googlesource.com/v8/v8/+/9c8f0f09ea6d6c08eeaf80019dd41da1762...
==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/v8/v8/+/9c8f0f09ea6d6c08eeaf80019dd41da1762... |
