Supply a valid Alert XPC identifier to the canary build

Supply a valid Alert XPC identifier to the canary build

BUG=720776
Review-Url: https://codereview.chromium.org/2917043002
Cr-Commit-Position: refs/heads/master@{#476624}
Committed: https://chromium.googlesource.com/chromium/src/+/c9e38c66b645acd86e626d4dfcd6712203ac293b

[Miguel Garcia, 2017-06-02 09:14:46]

miguelg@chromium.org changed reviewers:
+ mark@chromium.org

[Miguel Garcia, 2017-06-02 09:14:47]

I deleted the original issue by mistake, re-uploaded now.

[Mark Mentovai, 2017-06-02 12:32:04]

LGTM

https://codereview.chromium.org/2917043002/diff/1/chrome/installer/mac/sign_v...
File chrome/installer/mac/sign_versioned_dir.sh.in (right):

https://codereview.chromium.org/2917043002/diff/1/chrome/installer/mac/sign_v...
chrome/installer/mac/sign_versioned_dir.sh.in:118: "${xpc_plist}"
"CFBundleIdentifier")"
Use a hanging indent here, otherwise it looks like you’re running ${xpc_plist}.

[Miguel Garcia, 2017-06-02 12:45:15]

https://codereview.chromium.org/2917043002/diff/1/chrome/installer/mac/sign_v...
File chrome/installer/mac/sign_versioned_dir.sh.in (right):

https://codereview.chromium.org/2917043002/diff/1/chrome/installer/mac/sign_v...
chrome/installer/mac/sign_versioned_dir.sh.in:118: "${xpc_plist}"
"CFBundleIdentifier")"
On 2017/06/02 12:32:03, Mark Mentovai wrote:
> Use a hanging indent here, otherwise it looks like you’re running
${xpc_plist}.

Done.

[Miguel Garcia, 2017-06-02 12:45:18]

The CQ bit was checked by miguelg@chromium.org

[Miguel Garcia, 2017-06-02 12:45:19]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org
Link to the patchset: https://codereview.chromium.org/2917043002/#ps20001
(title: "review")

[commit-bot: I haz the power, 2017-06-02 12:45:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 12:56:03]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496407518728260,
"parent_rev": "e83e1b29bc3ea5dea7f0a53a427afedd11307c93", "commit_rev":
"c9e38c66b645acd86e626d4dfcd6712203ac293b"}

[commit-bot: I haz the power, 2017-06-02 12:56:12]

Description was changed from

==========
Supply a valid Alert XPC identifier to the canary build

BUG=720776
==========

to

==========
Supply a valid Alert XPC identifier to the canary build

BUG=720776

Review-Url: https://codereview.chromium.org/2917043002
Cr-Commit-Position: refs/heads/master@{#476624}
Committed:
https://chromium.googlesource.com/chromium/src/+/c9e38c66b645acd86e626d4dfcd6...
==========

[commit-bot: I haz the power, 2017-06-02 12:56:17]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c9e38c66b645acd86e626d4dfcd6...