Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3869)

Unified Diff: chrome/installer/mac/sign_versioned_dir.sh.in

Issue 2917043002: Supply a valid Alert XPC identifier to the canary build (Closed)
Patch Set: review Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/mac/sign_versioned_dir.sh.in
diff --git a/chrome/installer/mac/sign_versioned_dir.sh.in b/chrome/installer/mac/sign_versioned_dir.sh.in
index 4e5640b8b0d830c2aeff73f3ead6d1ba2f332d26..a9db32c8ec17629f745eff38a6c732124a21f63e 100644
--- a/chrome/installer/mac/sign_versioned_dir.sh.in
+++ b/chrome/installer/mac/sign_versioned_dir.sh.in
@@ -112,9 +112,13 @@ codesign_with_options "${app_mode_loader_tmp}" \
cp "${app_mode_loader_tmp}" "${app_mode_loader}"
rm -f "${app_mode_loader_tmp}"
+xpc_plist="${notification_service}/Contents/Info"
+xpc_bundle_id="$(__CFPREFERENCES_AVOID_DAEMON=1 defaults read \
+ "${xpc_plist}" "CFBundleIdentifier")"
+
codesign_with_options "${notification_service}" \
"${enforcement_flags_helpers}" \
- "com.google.Chrome.framework.AlertNotificationService"
+ "${xpc_bundle_id}"
# Only sign widevine plugin if it is present in the bundle.
# ${enforcement_flags*} are meaningless for dynamic libraries.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698