components/translate/core/common/language_detection_logging_helper.h - Issue 2916873004: Quick fix for logging.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/translate/core/common/language_detection_logging_helper.h

Issue 2916873004: Quick fix for logging. (Closed)

Patch Set: just use IsTranslatebleURL. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/translate/chrome_translate_client.cc ('K') | « chrome/browser/translate/chrome_translate_client.cc ('k') | components/translate/core/common/language_detection_logging_helper.cc » ('j') | components/translate/core/common/language_detection_logging_helper_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/translate/core/common/language_detection_logging_helper.h

diff --git a/components/translate/core/common/language_detection_logging_helper.h b/components/translate/core/common/language_detection_logging_helper.h

index d8f67bba66fb925aa17b571e02e10b90ad0307c5..ecd56510645e00f2d986c214e1749bb7636e1f97 100644

--- a/components/translate/core/common/language_detection_logging_helper.h

+++ b/components/translate/core/common/language_detection_logging_helper.h

@@ -15,7 +15,10 @@ namespace translate {

struct LanguageDetectionDetails;

+// Construct language detection based on navigation_id and language detection

+// details.

std::unique_ptr<sync_pb::UserEventSpecifics> ConstructLanguageDetectionEvent(

+ int navigation_id,

skym 2017/06/02 21:22:40 I think int is 4 bytes, while base::Time::ToIntern

renjieliu1 2017/06/05 06:39:19 thank you for the catch!

const LanguageDetectionDetails& details);

} // namespace translate