components/translate/core/common/language_detection_logging_helper.h - Issue 2916873004: Quick fix for logging.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/translate/core/common/language_detection_logging_helper.h

Issue 2916873004: Quick fix for logging. (Closed)

Patch Set: just use IsTranslatebleURL. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/translate/chrome_translate_client.cc ('K') | « chrome/browser/translate/chrome_translate_client.cc ('k') | components/translate/core/common/language_detection_logging_helper.cc » ('j') | components/translate/core/common/language_detection_logging_helper_unittest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2017 The Chromium Authors. All rights reserved.	1 // Copyright 2017 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef COMPONENTS_TRANSLATE_CORE_COMMON_LANGUAGE_DETECTION_LOGGING_HELPER_H_	5 #ifndef COMPONENTS_TRANSLATE_CORE_COMMON_LANGUAGE_DETECTION_LOGGING_HELPER_H_

6 #define COMPONENTS_TRANSLATE_CORE_COMMON_LANGUAGE_DETECTION_LOGGING_HELPER_H_	6 #define COMPONENTS_TRANSLATE_CORE_COMMON_LANGUAGE_DETECTION_LOGGING_HELPER_H_

7	7

8 #include <memory>	8 #include <memory>

9	9

10 namespace sync_pb {	10 namespace sync_pb {

11 class UserEventSpecifics;	11 class UserEventSpecifics;

12 }	12 }

13	13

14 namespace translate {	14 namespace translate {

15	15

16 struct LanguageDetectionDetails;	16 struct LanguageDetectionDetails;

17	17

	18 // Construct language detection based on navigation_id and language detection

	19 // details.

18 std::unique_ptr<sync_pb::UserEventSpecifics> ConstructLanguageDetectionEvent(	20 std::unique_ptr<sync_pb::UserEventSpecifics> ConstructLanguageDetectionEvent(

	21 int navigation_id,
	skym 2017/06/02 21:22:40 I think int is 4 bytes, while base::Time::ToIntern I think int is 4 bytes, while base::Time::ToInternalValue() is int64_t, which is definitely 8 bytes. I'm pretty sure this is going to mangle the number and bad things are going to happen. auto now = base::Time::Now().ToInternalValue(); LOG(ERROR) << "SKYM now: " << now; int int_now = now; LOG(ERROR) << "SKYM int_now: " << int_now; Show quoted text > SKYM now: 13140911818057375 > SKYM int_now: -185555297 renjieliu1 2017/06/05 06:39:19 thank you for the catch! Show quoted text On 2017/06/02 21:22:40, skym wrote: > I think int is 4 bytes, while base::Time::ToInternalValue() is int64_t, which is > definitely 8 bytes. I'm pretty sure this is going to mangle the number and bad > things are going to happen. > > auto now = base::Time::Now().ToInternalValue(); > LOG(ERROR) << "SKYM now: " << now; > int int_now = now; > LOG(ERROR) << "SKYM int_now: " << int_now; > > > SKYM now: 13140911818057375 > > SKYM int_now: -185555297 thank you for the catch!
19 const LanguageDetectionDetails& details);	22 const LanguageDetectionDetails& details);

20	23

21 } // namespace translate	24 } // namespace translate

22	25

23 #endif // COMPONENTS_TRANSLATE_CORE_COMMON_LANGUAGE_DETECTION_LOGGING_HELPER_H_	26 #endif // COMPONENTS_TRANSLATE_CORE_COMMON_LANGUAGE_DETECTION_LOGGING_HELPER_H_

OLD	NEW