 Chromium Code Reviews
 Chromium Code Reviews Issue 2916873004:
  Quick fix for logging.  (Closed)
    
  
    Issue 2916873004:
  Quick fix for logging.  (Closed) 
  | Index: components/translate/core/common/language_detection_logging_helper_unittest.cc | 
| diff --git a/components/translate/core/common/language_detection_logging_helper_unittest.cc b/components/translate/core/common/language_detection_logging_helper_unittest.cc | 
| index 6dc27c098ce4f28afecad35d2e511150b4145f52..cb1a8ce99a039072cd60db2463c4d3c8c1dfb53c 100644 | 
| --- a/components/translate/core/common/language_detection_logging_helper_unittest.cc | 
| +++ b/components/translate/core/common/language_detection_logging_helper_unittest.cc | 
| @@ -25,7 +25,9 @@ TEST(LanguageDetectionLoggingHelperTest, ConstructUserEventSpecifics) { | 
| lang->set_is_reliable(details.is_cld_reliable); | 
| lang_detection.set_adopted_language_code(details.adopted_language); | 
| const std::unique_ptr<sync_pb::UserEventSpecifics> user_event = | 
| - ConstructLanguageDetectionEvent(details); | 
| + ConstructLanguageDetectionEvent(100, details); | 
| 
skym
2017/06/02 21:22:40
Probably should have a test case that uses a numbe
 
renjieliu1
2017/06/05 06:39:19
Done.
 | 
| + // Expect the navigation id is correctly set. | 
| + EXPECT_EQ(user_event->navigation_id(), 100); | 
| EXPECT_EQ(user_event->language_detection().SerializeAsString(), | 
| lang_detection.SerializeAsString()); | 
| } | 
| @@ -43,7 +45,9 @@ TEST(LanguageDetectionLoggingHelperTest, DontSetAdoptedLanguage) { | 
| lang->set_language_code(details.cld_language); | 
| lang->set_is_reliable(details.is_cld_reliable); | 
| const std::unique_ptr<sync_pb::UserEventSpecifics> user_event = | 
| - ConstructLanguageDetectionEvent(details); | 
| + ConstructLanguageDetectionEvent(100, details); | 
| + // Expect the navigation id is correctly set. | 
| + EXPECT_EQ(user_event->navigation_id(), 100); | 
| EXPECT_EQ(user_event->language_detection().SerializeAsString(), | 
| lang_detection.SerializeAsString()); | 
| } |