Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2916853002: [arm64] Add monitor notifiers to NEON loads and stores. (Closed)

Created:
3 years, 6 months ago by martyn.capewell
Modified:
3 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Add monitor notifiers to NEON loads and stores. NEON loads and stores need notifiers for the local and global memory access monitors. Add these whilst removing the address argument from the notifier, making implementation simpler. BUG= Review-Url: https://codereview.chromium.org/2916853002 Cr-Commit-Position: refs/heads/master@{#45755} Committed: https://chromium.googlesource.com/v8/v8/+/074b0464e2b4b301dec2f6b528537e8fff957290

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -34 lines) Patch
M src/arm64/simulator-arm64.h View 3 chunks +4 lines, -4 lines 0 comments Download
M src/arm64/simulator-arm64.cc View 11 chunks +48 lines, -30 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
martyn.capewell
3 years, 6 months ago (2017-06-01 10:23:24 UTC) #2
bbudge
lgtm
3 years, 6 months ago (2017-06-01 17:23:19 UTC) #3
martyn.capewell
Benedikt - can I have a lgtm from an OWNER too?
3 years, 6 months ago (2017-06-07 09:38:35 UTC) #4
Benedikt Meurer
LGTM (rubber-stamped)
3 years, 6 months ago (2017-06-07 09:38:53 UTC) #5
martyn.capewell
Thanks.
3 years, 6 months ago (2017-06-07 09:39:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2916853002/1
3 years, 6 months ago (2017-06-07 09:40:02 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 10:07:28 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/074b0464e2b4b301dec2f6b528537e8fff9...

Powered by Google App Engine
This is Rietveld 408576698