Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2916753003: Add DISALLOW_COPY_AND_ASSIGN to TextMatchMarker (Closed)

Created:
3 years, 6 months ago by rlanday
Modified:
3 years, 6 months ago
Reviewers:
yosin_UTC9, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add DISALLOW_COPY_AND_ASSIGN to TextMatchMarker We're adding DISALLOW_COPY_AND_ASSIGN to CompositionMarker in https://codereview.chromium.org/2908643002 and to SpellingMarker and GrammarMarker in https://codereview.chromium.org/2911723002, so we should add it to TextMatchMarker as well for consistency. BUG=707867 Review-Url: https://codereview.chromium.org/2916753003 Cr-Commit-Position: refs/heads/master@{#476216} Committed: https://chromium.googlesource.com/chromium/src/+/7059102e597d59abf00aa67caa4a7b39266190fa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/Source/core/editing/markers/TextMatchMarker.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
rlanday
3 years, 6 months ago (2017-06-01 05:22:46 UTC) #3
yosin_UTC9
lgtm
3 years, 6 months ago (2017-06-01 05:39:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2916753003/1
3 years, 6 months ago (2017-06-01 05:40:04 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 07:01:39 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7059102e597d59abf00aa67caa4a...

Powered by Google App Engine
This is Rietveld 408576698