Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 2916493002: Make SelectionState enum class (Closed)

Created:
3 years, 6 months ago by yoichio
Modified:
3 years, 6 months ago
Reviewers:
yosin_UTC9, kojii
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make SelectionState enum class This CL mainly changes core/layout/api/SelectionState.*. We won't increase the enum members so just go straight forward definition not using macro. Also this CL changes SelectionStateBoth to SelectionState::kStartAndEnd because we have 5 members and 'both' is ambiguous. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2916493002 Cr-Commit-Position: refs/heads/master@{#475853} Committed: https://chromium.googlesource.com/chromium/src/+/12d918f97bd71b6e0d6e70ee480d000f769da669

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -125 lines) Patch
M third_party/WebKit/Source/core/editing/InputMethodController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/LayoutSelection.cpp View 7 chunks +11 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 1 chunk +7 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutListMarker.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutReplaced.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutText.cpp View 4 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/api/SelectionState.h View 1 chunk +14 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/layout/api/SelectionState.cpp View 1 chunk +14 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/layout/api/SelectionStateTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/EllipsisBox.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp View 5 chunks +23 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp View 3 chunks +17 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/page/TouchAdjustment.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BoxClipper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ListMarkerPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PartPainter.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ReplacedPainter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/SVGRootInlineBoxPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (11 generated)
yoichio
3 years, 6 months ago (2017-05-31 05:28:30 UTC) #7
kojii
lgtm
3 years, 6 months ago (2017-05-31 05:48:56 UTC) #10
yosin_UTC9
lgtm Thanks!
3 years, 6 months ago (2017-05-31 05:55:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2916493002/1
3 years, 6 months ago (2017-05-31 07:00:26 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 09:10:03 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/12d918f97bd71b6e0d6e70ee480d...

Powered by Google App Engine
This is Rietveld 408576698