third_party/WebKit/Source/core/layout/LayoutBox.cpp - Issue 2916493002: Make SelectionState enum class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2916493002: Make SelectionState enum class (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

index da017f7e1c8ef06127f5e0919130371e52a08539..da87d16bbd6a84fd1d2535ed9e0c73252731b235 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

@@ -2403,7 +2403,8 @@ bool LayoutBox::NeedsForcedBreakBefore(

}

bool LayoutBox::PaintedOutputOfObjectHasNoEffectRegardlessOfSize() const {

- if (HasNonCompositedScrollbars() || GetSelectionState() != SelectionNone ||

+ if (HasNonCompositedScrollbars() ||

+ GetSelectionState() != SelectionState::kNone ||

HasBoxDecorationBackground() || StyleRef().HasBoxDecorations() ||

StyleRef().HasVisualOverflowingEffect())

return false;