Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2916413002: Omnibox UI Experiments: Suggestions Dropdown width experiment on Cocoa (Closed)

Created:
3 years, 6 months ago by tommycli
Modified:
3 years, 6 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews, jdonnelly+watch_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Omnibox UI Experiments: Suggestions Dropdown width experiment on Cocoa Implements https://codereview.chromium.org/2914163004/ on Cocoa. Supports an experimental flag to match the Omnibox suggestion dropdown width to Omnibox width. BUG=728844 Review-Url: https://codereview.chromium.org/2916413002 Cr-Commit-Position: refs/heads/master@{#478363} Committed: https://chromium.googlesource.com/chromium/src/+/619e52d6d7e054dfffb13053af73204fa6d0eb69

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -9 lines) Patch
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm View 1 4 chunks +19 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
tommycli
groby: PTAL, thanks! upstream CL in description. Screenshots in bug.
3 years, 6 months ago (2017-06-02 21:44:50 UTC) #7
groby-ooo-7-16
lgtm
3 years, 6 months ago (2017-06-07 16:54:48 UTC) #8
tommycli
On 2017/06/07 16:54:48, groby wrote: > lgtm thanks! will send in as soon as the ...
3 years, 6 months ago (2017-06-07 17:09:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2916413002/20001
3 years, 6 months ago (2017-06-09 18:53:19 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 19:14:09 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/619e52d6d7e054dfffb13053af73...

Powered by Google App Engine
This is Rietveld 408576698