Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2906893004: Omnibox UI Experiments: Port Vertical Layout experiment to Mac Cocoa. (Closed)

Created:
3 years, 7 months ago by tommycli
Modified:
3 years, 6 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews, jdonnelly+watch_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Omnibox UI Experiments: Port Vertical Layout experiment to Mac Cocoa. Ports https://codereview.chromium.org/2901953002 Omnibox vertical layout experiment to Mac Cocoa. BUG=725599 Review-Url: https://codereview.chromium.org/2906893004 Cr-Commit-Position: refs/heads/master@{#476001} Committed: https://chromium.googlesource.com/chromium/src/+/81081694021693dc29c3ff9bde3da5003510a0ce

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix camel case #

Total comments: 15

Patch Set 3 : address groby@ comments #

Patch Set 4 : fix usage of BOOL #

Patch Set 5 : fix a mistake... #

Patch Set 6 : Prevent dimming in swap case #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -29 lines) Patch
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm View 1 2 3 4 5 10 chunks +55 lines, -26 lines 3 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.mm View 1 2 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
tommycli
groby: PTAL, should be a straight port of changes in https://codereview.chromium.org/2901953002/diff/60001/chrome/browser/ui/views/omnibox/omnibox_result_view.cc Screenshots in bug. Thanks! ...
3 years, 7 months ago (2017-05-26 22:28:14 UTC) #2
groby-ooo-7-16
https://codereview.chromium.org/2906893004/diff/20001/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h File chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h (right): https://codereview.chromium.org/2906893004/diff/20001/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h#newcode71 chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h:71: + (CGFloat)getContentTextHeight:(BOOL)isTwoLine; Goal for cocoa functions is usually to ...
3 years, 6 months ago (2017-05-31 00:14:51 UTC) #7
tommycli
groby: thanks! https://codereview.chromium.org/2906893004/diff/20001/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h File chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h (right): https://codereview.chromium.org/2906893004/diff/20001/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h#newcode71 chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h:71: + (CGFloat)getContentTextHeight:(BOOL)isTwoLine; On 2017/05/31 00:14:51, groby wrote: ...
3 years, 6 months ago (2017-05-31 18:20:40 UTC) #10
groby-ooo-7-16
LGTM % text formatting issue. https://codereview.chromium.org/2906893004/diff/20001/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm File chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm (right): https://codereview.chromium.org/2906893004/diff/20001/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm#newcode563 chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm:563: origin.x = left; On ...
3 years, 6 months ago (2017-05-31 19:24:17 UTC) #13
tommycli
thanks! https://codereview.chromium.org/2906893004/diff/100001/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm File chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm (right): https://codereview.chromium.org/2906893004/diff/100001/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm#newcode436 chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm:436: : DimTextColor(isDarkTheme), On 2017/05/31 19:24:17, groby wrote: > ...
3 years, 6 months ago (2017-05-31 20:07:22 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2906893004/100001
3 years, 6 months ago (2017-05-31 20:08:22 UTC) #18
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 20:33:35 UTC) #21
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/81081694021693dc29c3ff9bde3d...

Powered by Google App Engine
This is Rietveld 408576698