Disable custom libcxx on mac fuzzer builds

Disable custom libcxx on mac fuzzer builds

BUG=729032
R=thakis@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_chromium_asan_rel_ng

Review-Url: https://codereview.chromium.org/2916363003
Cr-Commit-Position: refs/heads/master@{#476809}
Committed: https://chromium.googlesource.com/chromium/src/+/420f4637737c8a0232941c7099b8b9bbb42b5fee

[Tom Anderson, 2017-06-02 19:30:13]

Description was changed from

==========
Disable custom libcxx on mac fuzzer builds

BUG=729032
==========

to

==========
Disable custom libcxx on mac fuzzer builds

BUG=729032
R=thakis@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_chromium_asan_rel_ng
==========

[Tom Anderson, 2017-06-02 19:30:13]

thomasanderson@chromium.org changed reviewers:
+ thakis@chromium.org

[Tom Anderson, 2017-06-02 19:30:19]

The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 19:31:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Anderson, 2017-06-02 20:27:40]

thakis ptal

https://codereview.chromium.org/2916363003/diff/1/build/config/sanitizers/san...
File build/config/sanitizers/sanitizers.gni (right):

https://codereview.chromium.org/2916363003/diff/1/build/config/sanitizers/san...
build/config/sanitizers/sanitizers.gni:142: is_ubsan_security || (use_libfuzzer
&& !is_mac) || use_afl
Should this entire thing be wrapped in "is_linux && !is_chromeos"?

[Nico, 2017-06-02 20:38:34]

thakis@chromium.org changed reviewers:
+ mmoroz@chromium.org

[Nico, 2017-06-02 20:38:35]

lgtm

mmoroz, please shout if we require an instrumented libc++ for fuzzers.

(i'm afk now until jun 11)

https://codereview.chromium.org/2916363003/diff/1/build/config/sanitizers/san...
File build/config/sanitizers/sanitizers.gni (right):

https://codereview.chromium.org/2916363003/diff/1/build/config/sanitizers/san...
build/config/sanitizers/sanitizers.gni:142: is_ubsan_security || (use_libfuzzer
&& !is_mac) || use_afl
On 2017/06/02 20:27:40, Tom Anderson wrote:
> Should this entire thing be wrapped in "is_linux && !is_chromeos"?

I think we use it on android too.

[mmoroz, 2017-06-02 20:45:26]

LGTM

I think we need an instrumented libc++ only for MSan, but we don't use MSan on
Mac as of now.

[commit-bot: I haz the power, 2017-06-02 21:00:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 21:00:35]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Tom Anderson, 2017-06-02 21:09:28]

The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 21:10:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 22:01:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 22:01:50]

Dry run: This issue passed the CQ dry run.

[Tom Anderson, 2017-06-02 22:02:14]

The CQ bit was checked by thomasanderson@chromium.org

[commit-bot: I haz the power, 2017-06-02 22:02:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 22:07:54]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496440934137860, "parent_rev":
"d71aa8beba49aa8dc7814176e8795243035b4d05", "commit_rev":
"420f4637737c8a0232941c7099b8b9bbb42b5fee"}

[commit-bot: I haz the power, 2017-06-02 22:08:04]

Description was changed from

==========
Disable custom libcxx on mac fuzzer builds

BUG=729032
R=thakis@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_chromium_asan_rel_ng
==========

to

==========
Disable custom libcxx on mac fuzzer builds

BUG=729032
R=thakis@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_chromium_asan_rel_ng

Review-Url: https://codereview.chromium.org/2916363003
Cr-Commit-Position: refs/heads/master@{#476809}
Committed:
https://chromium.googlesource.com/chromium/src/+/420f4637737c8a0232941c7099b8...
==========

[commit-bot: I haz the power, 2017-06-02 22:08:05]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/420f4637737c8a0232941c7099b8...