Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Side by Side Diff: build/config/sanitizers/sanitizers.gni

Issue 2916363003: Disable custom libcxx on mac fuzzer builds (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/chrome_build.gni") 5 import("//build/config/chrome_build.gni")
6 import("//build/toolchain/toolchain.gni") 6 import("//build/toolchain/toolchain.gni")
7 7
8 declare_args() { 8 declare_args() {
9 # Compile for Address Sanitizer to find memory bugs. 9 # Compile for Address Sanitizer to find memory bugs.
10 is_asan = false 10 is_asan = false
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 132
133 # Args that are in turn dependent on other args must be in a separate 133 # Args that are in turn dependent on other args must be in a separate
134 # declare_args block. User overrides are only applied at the end of a 134 # declare_args block. User overrides are only applied at the end of a
135 # declare_args block. 135 # declare_args block.
136 declare_args() { 136 declare_args() {
137 # Use libc++ (buildtools/third_party/libc++ and 137 # Use libc++ (buildtools/third_party/libc++ and
138 # buildtools/third_party/libc++abi) instead of stdlibc++ as standard library. 138 # buildtools/third_party/libc++abi) instead of stdlibc++ as standard library.
139 # This is intended to be used for instrumented builds. 139 # This is intended to be used for instrumented builds.
140 use_custom_libcxx = 140 use_custom_libcxx =
141 (is_asan && is_linux && !is_chromeos) || is_tsan || is_msan || is_ubsan || 141 (is_asan && is_linux && !is_chromeos) || is_tsan || is_msan || is_ubsan ||
142 is_ubsan_security || use_libfuzzer || use_afl 142 is_ubsan_security || (use_libfuzzer && !is_mac) || use_afl
Tom Anderson 2017/06/02 20:27:40 Should this entire thing be wrapped in "is_linux &
Nico 2017/06/02 20:38:35 I think we use it on android too.
143 143
144 # Enable -fsanitize-coverage. 144 # Enable -fsanitize-coverage.
145 use_sanitizer_coverage = 145 use_sanitizer_coverage =
146 use_libfuzzer || use_afl || sanitizer_coverage_flags != "" 146 use_libfuzzer || use_afl || sanitizer_coverage_flags != ""
147 147
148 # Detect overflow/underflow for global objects. 148 # Detect overflow/underflow for global objects.
149 # 149 #
150 # Mac: http://crbug.com/352073 150 # Mac: http://crbug.com/352073
151 asan_globals = !is_mac 151 asan_globals = !is_mac
152 } 152 }
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
194 assert(!is_debug || !(is_msan || is_ubsan || is_ubsan_null || is_ubsan_vptr), 194 assert(!is_debug || !(is_msan || is_ubsan || is_ubsan_null || is_ubsan_vptr),
195 "Sanitizers should generally be used in release (set is_debug=false).") 195 "Sanitizers should generally be used in release (set is_debug=false).")
196 196
197 assert(!is_msan || (is_linux && current_cpu == "x64"), 197 assert(!is_msan || (is_linux && current_cpu == "x64"),
198 "MSan currently only works on 64-bit Linux and ChromeOS builds.") 198 "MSan currently only works on 64-bit Linux and ChromeOS builds.")
199 199
200 # ASAN build on Windows is not working in debug mode. Intercepting memory 200 # ASAN build on Windows is not working in debug mode. Intercepting memory
201 # allocation functions is hard on Windows and not yet implemented in LLVM. 201 # allocation functions is hard on Windows and not yet implemented in LLVM.
202 assert(!is_win || !is_debug || !is_asan, 202 assert(!is_win || !is_debug || !is_asan,
203 "ASan on Windows doesn't work in debug (set is_debug=false).") 203 "ASan on Windows doesn't work in debug (set is_debug=false).")
OLDNEW
« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698