Fix CompositorSurfaceManager synthetic surfaceCreated arg order.

Fix CompositorSurfaceManager synthetic surfaceCreated arg order.

When sending a synthetic surfaceChanged to the client, CSM swapped
the order of the width, height pair with the surface format.  As a
result, the compositor got the wrong value for all of them.

This CL also updates the test to check for this case, since it was
using anyInt() in the matchers previously.

BUG=728790
TEST=CompositorSurfaceManagerTest

Review-Url: https://codereview.chromium.org/2916153002
Cr-Commit-Position: refs/heads/master@{#476706}
Committed: https://chromium.googlesource.com/chromium/src/+/4b1deb98719a901d1050f200e64d9164d1b2912b

[liberato (no reviews please), 2017-06-01 21:18:31]

The CQ bit was checked by liberato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 21:19:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[liberato (no reviews please), 2017-06-01 21:23:11]

Description was changed from

==========
Fix CompositorSurfaceManager synthetic surfaceCreated arg order.

When sending a synthetic surfaceChanged to the client, CSM swapped
the order of the width, height pair with the surface format.  As a
result, the compositor got the wrong value for all of them.

This CL also updates the test to check for this case, since it was
using anyInt() in the matchers previously.

BUG=728790
TEST=CompositorSurfaceManagerTest
==========

to

==========
Fix CompositorSurfaceManager synthetic surfaceCreated arg order.

When sending a synthetic surfaceChanged to the client, CSM swapped
the order of the width, height pair with the surface format.  As a
result, the compositor got the wrong value for all of them.

This CL also updates the test to check for this case, since it was
using anyInt() in the matchers previously.

BUG=728790
TEST=CompositorSurfaceManagerTest
==========

[liberato (no reviews please), 2017-06-01 21:23:11]

liberato@chromium.org changed reviewers:
+ tedchoc@chromium.org

[liberato (no reviews please), 2017-06-01 21:25:53]

hi -- this CL fixes something that i broke.  :)

luckily, the bad call doesn't seem to occur in practice.  it does happen in some
new stuff that tguilbert@ is working on, which is how we found it.

thanks
-fl

[commit-bot: I haz the power, 2017-06-01 22:46:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 22:46:18]

Dry run: This issue passed the CQ dry run.

[Ted C, 2017-06-01 23:27:27]

lgtm

https://codereview.chromium.org/2916153002/diff/1/chrome/android/junit/src/or...
File
chrome/android/junit/src/org/chromium/chrome/browser/compositor/CompositorSurfaceManagerTest.java
(right):

https://codereview.chromium.org/2916153002/diff/1/chrome/android/junit/src/or...
chrome/android/junit/src/org/chromium/chrome/browser/compositor/CompositorSurfaceManagerTest.java:57:
int mActualFormat;
private for all of these?

[liberato (no reviews please), 2017-06-02 05:42:07]

thanks
-fl

https://codereview.chromium.org/2916153002/diff/1/chrome/android/junit/src/or...
File
chrome/android/junit/src/org/chromium/chrome/browser/compositor/CompositorSurfaceManagerTest.java
(right):

https://codereview.chromium.org/2916153002/diff/1/chrome/android/junit/src/or...
chrome/android/junit/src/org/chromium/chrome/browser/compositor/CompositorSurfaceManagerTest.java:57:
int mActualFormat;
On 2017/06/01 23:27:27, Ted C wrote:
> private for all of these?

Done, i forgot which language...

[liberato (no reviews please), 2017-06-02 05:42:11]

The CQ bit was checked by liberato@chromium.org

[liberato (no reviews please), 2017-06-02 05:42:12]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2916153002/#ps20001
(title: "added private")

[commit-bot: I haz the power, 2017-06-02 05:42:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 07:29:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 07:29:05]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[liberato (no reviews please), 2017-06-02 16:48:02]

The CQ bit was checked by liberato@chromium.org

[commit-bot: I haz the power, 2017-06-02 16:48:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 17:30:47]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496422082188580,
"parent_rev": "92c0c2fb929a969c0ca9b7626e302360ece09f83", "commit_rev":
"4b1deb98719a901d1050f200e64d9164d1b2912b"}

[commit-bot: I haz the power, 2017-06-02 17:30:55]

Description was changed from

==========
Fix CompositorSurfaceManager synthetic surfaceCreated arg order.

When sending a synthetic surfaceChanged to the client, CSM swapped
the order of the width, height pair with the surface format.  As a
result, the compositor got the wrong value for all of them.

This CL also updates the test to check for this case, since it was
using anyInt() in the matchers previously.

BUG=728790
TEST=CompositorSurfaceManagerTest
==========

to

==========
Fix CompositorSurfaceManager synthetic surfaceCreated arg order.

When sending a synthetic surfaceChanged to the client, CSM swapped
the order of the width, height pair with the surface format.  As a
result, the compositor got the wrong value for all of them.

This CL also updates the test to check for this case, since it was
using anyInt() in the matchers previously.

BUG=728790
TEST=CompositorSurfaceManagerTest

Review-Url: https://codereview.chromium.org/2916153002
Cr-Commit-Position: refs/heads/master@{#476706}
Committed:
https://chromium.googlesource.com/chromium/src/+/4b1deb98719a901d1050f200e64d...
==========

[commit-bot: I haz the power, 2017-06-02 17:30:56]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4b1deb98719a901d1050f200e64d...