chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorSurfaceManager.java - Issue 2916153002: Fix CompositorSurfaceManager synthetic surfaceCreated arg order.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorSurfaceManager.java

Issue 2916153002: Fix CompositorSurfaceManager synthetic surfaceCreated arg order. (Closed)

Patch Set: added private Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/junit/src/org/chromium/chrome/browser/compositor/CompositorSurfaceManagerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorSurfaceManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorSurfaceManager.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorSurfaceManager.java

index cc924cd0c0bc61acdf23fdc4c3226fd5f9e75739..eda6e43dce8d8d4be970539720b577286806a72f 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorSurfaceManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorSurfaceManager.java

@@ -187,8 +187,8 @@ class CompositorSurfaceManager implements SurfaceHolder.Callback2 {

// See if we're expecting a surfaceChanged. If not, then send a synthetic one.

if (mOwnedByClient.format != PixelFormat.UNKNOWN) {

- mClient.surfaceChanged(mOwnedByClient.surfaceHolder(), mOwnedByClient.width,

- mOwnedByClient.height, mOwnedByClient.format);

+ mClient.surfaceChanged(mOwnedByClient.surfaceHolder(), mOwnedByClient.format,

+ mOwnedByClient.width, mOwnedByClient.height);

}

« no previous file with comments | « no previous file | chrome/android/junit/src/org/chromium/chrome/browser/compositor/CompositorSurfaceManagerTest.java » ('j') | no next file with comments »