Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issue 2916143003: handle WASM trap in the instruction scheduler. (Closed)

Created:
3 years, 6 months ago by Rodolph Perfetta (ARM)
Modified:
3 years, 6 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

handle WASM trap in the instruction scheduler. Review-Url: https://codereview.chromium.org/2916143003 Cr-Commit-Position: refs/heads/master@{#45694} Committed: https://chromium.googlesource.com/v8/v8/+/b015229c091cb064c101b28b8da477ef1a356bd6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -31 lines) Patch
M src/compiler/ia32/instruction-scheduler-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/instruction.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/instruction-scheduler.h View 3 chunks +22 lines, -15 lines 0 comments Download
M src/compiler/instruction-scheduler.cc View 5 chunks +10 lines, -12 lines 0 comments Download
M src/compiler/x64/instruction-scheduler-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Rodolph Perfetta (ARM)
Made the instruction scheduler aware of WASM traps.
3 years, 6 months ago (2017-06-02 00:01:57 UTC) #2
Jarin
lgtm, thanks!
3 years, 6 months ago (2017-06-02 08:20:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2916143003/1
3 years, 6 months ago (2017-06-02 15:46:14 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 16:17:50 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/b015229c091cb064c101b28b8da477ef1a3...

Powered by Google App Engine
This is Rietveld 408576698