src/compiler/x64/instruction-scheduler-x64.cc - Issue 2916143003: handle WASM trap in the instruction scheduler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/x64/instruction-scheduler-x64.cc

Issue 2916143003: handle WASM trap in the instruction scheduler. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/x64/instruction-scheduler-x64.cc

diff --git a/src/compiler/x64/instruction-scheduler-x64.cc b/src/compiler/x64/instruction-scheduler-x64.cc

index 862bca21a17e162a74f2d761b570bedd52a424c4..63f134c081810d17fbdd46c59410e748c33587b3 100644

--- a/src/compiler/x64/instruction-scheduler-x64.cc

+++ b/src/compiler/x64/instruction-scheduler-x64.cc

@@ -189,8 +189,8 @@ int InstructionScheduler::GetTargetInstructionFlags(

case kX64Udiv:

case kX64Udiv32:

return (instr->addressing_mode() == kMode_None)

- ? kMayNeedDeoptCheck

- : kMayNeedDeoptCheck | kIsLoadOperation | kHasSideEffect;

+ ? kMayNeedDeoptOrTrapCheck

+ : kMayNeedDeoptOrTrapCheck | kIsLoadOperation | kHasSideEffect;

case kX64Movsxbl:

case kX64Movzxbl:

« no previous file with comments | « src/compiler/instruction-scheduler.cc ('k') | no next file » | no next file with comments »