Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 2916093002: [ia32][wasm] Support AVX instructions for I32x4Splat/ReplaceLane/ExtractLane (Closed)

Created:
3 years, 6 months ago by Jing
Modified:
3 years, 6 months ago
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[ia32][wasm] Support AVX instructions for I32x4Splat/ReplaceLane/ExtractLane Add vpinsrd, vpextrd, vmovd. Supplement pshufd and add vpshufd. Add Movd and Pshufd macro. Add AVX support to Pextrd. Fix disassembler to recognize "pinsrd/pextrd xmm,[mem],imm8". BUG= Review-Url: https://codereview.chromium.org/2916093002 Cr-Commit-Position: refs/heads/master@{#45833} Committed: https://chromium.googlesource.com/v8/v8/+/6d18ae258983b092c593821595680d20f1723557

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -33 lines) Patch
M src/compiler/ia32/code-generator-ia32.cc View 2 chunks +11 lines, -4 lines 0 comments Download
M src/compiler/ia32/instruction-codes-ia32.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/ia32/instruction-scheduler-ia32.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 chunk +10 lines, -4 lines 0 comments Download
M src/ia32/assembler-ia32.h View 3 chunks +29 lines, -1 line 0 comments Download
M src/ia32/assembler-ia32.cc View 2 chunks +17 lines, -2 lines 0 comments Download
M src/ia32/disasm-ia32.cc View 6 chunks +50 lines, -19 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +23 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +15 lines, -1 line 0 comments Download
M test/cctest/test-disasm-ia32.cc View 4 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Pan
3 years, 6 months ago (2017-06-01 14:55:27 UTC) #2
bbudge
lgtm
3 years, 6 months ago (2017-06-01 17:30:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2916093002/1
3 years, 6 months ago (2017-06-03 14:37:32 UTC) #5
Jing
Hi Benedikt and Trofin, please take a look. Thanks!
3 years, 6 months ago (2017-06-05 05:56:25 UTC) #7
Jing
Ping Benedikt and Trofin. PTAL. Thanks!
3 years, 6 months ago (2017-06-09 02:48:31 UTC) #8
Mircea Trofin
On 2017/06/09 02:48:31, Jing wrote: > Ping Benedikt and Trofin. PTAL. Thanks! lgtm
3 years, 6 months ago (2017-06-09 03:32:37 UTC) #9
Benedikt Meurer
LGTM (rubber-stamped)
3 years, 6 months ago (2017-06-09 04:49:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2916093002/1
3 years, 6 months ago (2017-06-12 01:31:51 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-06-12 01:57:13 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/6d18ae258983b092c593821595680d20f17...

Powered by Google App Engine
This is Rietveld 408576698