Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2915893002: Modify visible url tests for embedded test server (Closed)

Created:
3 years, 6 months ago by huangml1
Modified:
3 years, 6 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Modify visible url tests for embedded test server. The ETS can not respond to a new request before the previous one is completed. These two tests verify receiving of new requests while the server is paused, which fails under ETS. The new requests will be handled after server starts again. Removing the checks do not change the purpose of the tests. We can still verify the new requests after the server is un-paused. Modify the tests and make it run under GCDWebServer on bots first in case we are missing some edge cases. BUG=724560 Review-Url: https://codereview.chromium.org/2915893002 Cr-Commit-Position: refs/heads/master@{#476064} Committed: https://chromium.googlesource.com/chromium/src/+/2c9727c3e7c09b51e7590f2cc429580f4a91f968

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M ios/chrome/browser/web/visible_url_egtest.mm View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
huangml1
PTAL, thanks!
3 years, 6 months ago (2017-05-31 20:14:44 UTC) #5
Eugene But (OOO till 7-30)
lgtm
3 years, 6 months ago (2017-05-31 22:12:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2915893002/1
3 years, 6 months ago (2017-05-31 22:16:19 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 22:28:55 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2c9727c3e7c09b51e7590f2cc429...

Powered by Google App Engine
This is Rietveld 408576698