Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: ios/chrome/browser/web/visible_url_egtest.mm

Issue 2915893002: Modify visible url tests for embedded test server (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/web/visible_url_egtest.mm
diff --git a/ios/chrome/browser/web/visible_url_egtest.mm b/ios/chrome/browser/web/visible_url_egtest.mm
index 7d16941a7ec433ebecf8aa0e420f98dc65c32f55..b6c4b21b58a2e653f101bb46d0072b9429460528 100644
--- a/ios/chrome/browser/web/visible_url_egtest.mm
+++ b/ios/chrome/browser/web/visible_url_egtest.mm
@@ -402,8 +402,8 @@ class PausableResponseProvider : public HtmlResponseProvider {
// pending URL.
[[EarlGrey selectElementWithMatcher:chrome_test_util::BackButton()]
performAction:grey_tap()];
- GREYAssert([self waitForServerToReceiveRequestWithURL:_testURL1],
- @"Last request URL: %@", self.lastRequestURLSpec);
+ // TODO(crbug.com/724560): Re-evaluate if necessary to check receiving URL1
+ // request here.
[[EarlGrey selectElementWithMatcher:OmniboxText(_testURL2.GetContent())]
assertWithMatcher:grey_notNil()];
@@ -432,8 +432,8 @@ class PausableResponseProvider : public HtmlResponseProvider {
// even though URL1 is a pending URL.
[[EarlGrey selectElementWithMatcher:chrome_test_util::BackButton()]
performAction:grey_tap()];
- GREYAssert([self waitForServerToReceiveRequestWithURL:_testURL1],
- @"Last request URL: %@", self.lastRequestURLSpec);
+ // TODO(crbug.com/724560): Re-evaluate if necessary to check receiving URL1
+ // request here.
[[EarlGrey selectElementWithMatcher:OmniboxText(_testURL2.GetContent())]
assertWithMatcher:grey_notNil()];
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698