Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2915883003: Revert of Fix some flaky tests: Use a dedicated temp dir. (Closed)

Created:
3 years, 6 months ago by Peter Kasting
Modified:
3 years, 6 months ago
Reviewers:
gsennton, Ilya Sherman
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix some flaky tests: Use a dedicated temp dir. (patchset #1 id:1 of https://codereview.chromium.org/2911983008/ ) Reason for revert: Looks to be causing consistent failures on Android, e.g.: https://luci-milo.appspot.com/buildbot/chromium.linux/Android%20Tests/42292 Original issue's description: > Fix some flaky tests: Use a dedicated temp dir. > > BUG=725379 > TEST=CrashDumpManagerTest.* > R=gsennton@chromium.org > > Review-Url: https://codereview.chromium.org/2911983008 > Cr-Commit-Position: refs/heads/master@{#475924} > Committed: https://chromium.googlesource.com/chromium/src/+/6b0e73063c6d65e7172cd247e05006078a60cf23 TBR=gsennton@chromium.org,isherman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=725379 Review-Url: https://codereview.chromium.org/2915883003 Cr-Commit-Position: refs/heads/master@{#475991} Committed: https://chromium.googlesource.com/chromium/src/+/f6c031634d0e361e90534d410121d25c991b3a80

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -10 lines) Patch
M components/crash/android/javatests/src/org/chromium/components/crash/browser/CrashDumpManagerTest.java View 4 chunks +15 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Peter Kasting
Created Revert of Fix some flaky tests: Use a dedicated temp dir.
3 years, 6 months ago (2017-05-31 20:01:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2915883003/1
3 years, 6 months ago (2017-05-31 20:02:22 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 20:02:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f6c031634d0e361e90534d410121...

Powered by Google App Engine
This is Rietveld 408576698