Fix some flaky tests: Use a dedicated temp dir.

Fix some flaky tests: Use a dedicated temp dir.

BUG=725379
TEST=CrashDumpManagerTest.*
R=gsennton@chromium.org

Review-Url: https://codereview.chromium.org/2911983008
Cr-Commit-Position: refs/heads/master@{#475924}
Committed: https://chromium.googlesource.com/chromium/src/+/6b0e73063c6d65e7172cd247e05006078a60cf23

[Ilya Sherman, 2017-05-30 22:58:15]

The CQ bit was checked by isherman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 22:59:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 00:29:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 00:29:26]

Dry run: This issue passed the CQ dry run.

[gsennton, 2017-05-31 13:51:06]

lgtm, thanks Ilya!

[Ilya Sherman, 2017-05-31 15:46:21]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2017-05-31 15:46:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 15:52:20]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496245581466110, "parent_rev":
"3b086a00604e32aae95f66c058cd3f5946a2484d", "commit_rev":
"6b0e73063c6d65e7172cd247e05006078a60cf23"}

[commit-bot: I haz the power, 2017-05-31 15:52:29]

Description was changed from

==========
Fix some flaky tests: Use a dedicated temp dir.

BUG=725379
TEST=CrashDumpManagerTest.*
R=gsennton@chromium.org
==========

to

==========
Fix some flaky tests: Use a dedicated temp dir.

BUG=725379
TEST=CrashDumpManagerTest.*
R=gsennton@chromium.org

Review-Url: https://codereview.chromium.org/2911983008
Cr-Commit-Position: refs/heads/master@{#475924}
Committed:
https://chromium.googlesource.com/chromium/src/+/6b0e73063c6d65e7172cd247e050...
==========

[commit-bot: I haz the power, 2017-05-31 15:52:30]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6b0e73063c6d65e7172cd247e050...

[Peter Kasting, 2017-05-31 20:01:03]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2915883003/ by pkasting@chromium.org.

The reason for reverting is: Looks to be causing consistent failures on Android,
e.g.:

https://luci-milo.appspot.com/buildbot/chromium.linux/Android%20Tests/42292.

[jbudorick, 2017-06-01 03:44:32]

jbudorick@chromium.org changed reviewers:
+ jbudorick@chromium.org

[jbudorick, 2017-06-01 03:44:32]

https://codereview.chromium.org/2911983008/diff/1/components/crash/android/ja...
File
components/crash/android/javatests/src/org/chromium/components/crash/browser/CrashDumpManagerTest.java
(right):

https://codereview.chromium.org/2911983008/diff/1/components/crash/android/ja...
components/crash/android/javatests/src/org/chromium/components/crash/browser/CrashDumpManagerTest.java:34:
assert mTempDir.mkdirs();
I think this should be

  Assert.assertTrue(mTempDir.mkdirs());

The language assert behaves somewhat inconsistently on android.

[Ilya Sherman, 2017-06-02 00:06:08]

https://codereview.chromium.org/2911983008/diff/1/components/crash/android/ja...
File
components/crash/android/javatests/src/org/chromium/components/crash/browser/CrashDumpManagerTest.java
(right):

https://codereview.chromium.org/2911983008/diff/1/components/crash/android/ja...
components/crash/android/javatests/src/org/chromium/components/crash/browser/CrashDumpManagerTest.java:34:
assert mTempDir.mkdirs();
On 2017/06/01 03:44:32, jbudorick wrote:
> I think this should be
> 
>   Assert.assertTrue(mTempDir.mkdirs());
> 
> The language assert behaves somewhat inconsistently on android.

Yeah, not sure why I wrote a language assert there... I'll fix this as part of [
https://codereview.chromium.org/2915013002/ ].  However, it's still not clear to
me why the tests are failing overall -- I do think this assertion might be
failing, but I don't understand why it would fail.