third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js - Issue 2915883002: DevTools: prepare to unify Network and CPU throttling UI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

Issue 2915883002: DevTools: prepare to unify Network and CPU throttling UI (Closed)

Patch Set: gs Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartNetworkDataProvider.js ('k') | third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

index faa7317bc5eeb86eb46b0103b074955738d6966b..5a5dd7b97560293f48485a073b7a1d943e977411 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

@@ -71,7 +71,7 @@ Timeline.TimelinePanel = class extends UI.Panel {

/** @type {?Timeline.PerformanceModel} */

this._pendingPerformanceModel = null;

- this._cpuThrottlingManager = new Components.CPUThrottlingManager();

+ this._cpuThrottlingManager = new MobileThrottling.CPUThrottlingManager();

this._viewModeSetting =

Common.settings.createSetting('timelineViewMode', Timeline.TimelinePanel.ViewMode.FlameChart);

@@ -260,7 +260,7 @@ Timeline.TimelinePanel = class extends UI.Panel {

SDK.multitargetNetworkManager.addEventListener(

SDK.MultitargetNetworkManager.Events.ConditionsChanged, this._updateShowSettingsToolbarButton, this);

this._cpuThrottlingManager.addEventListener(

- Components.CPUThrottlingManager.Events.RateChanged, this._updateShowSettingsToolbarButton, this);

+ MobileThrottling.CPUThrottlingManager.Events.RateChanged, this._updateShowSettingsToolbarButton, this);

this._disableCaptureJSProfileSetting.addChangeListener(this._updateShowSettingsToolbarButton, this);

this._captureLayersAndPicturesSetting.addChangeListener(this._updateShowSettingsToolbarButton, this);

@@ -324,7 +324,7 @@ Timeline.TimelinePanel = class extends UI.Panel {

_createNetworkConditionsSelect() {

var toolbarItem = new UI.ToolbarComboBox(null);

toolbarItem.setMaxWidth(140);

- NetworkConditions.NetworkConditionsSelector.decorateSelect(toolbarItem.selectElement());

+ MobileThrottling.NetworkConditionsSelector.decorateSelect(toolbarItem.selectElement());

return toolbarItem;

}