Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 2915873003: This QUIC change includes: (Closed)

Created:
3 years, 6 months ago by Jana
Modified:
3 years, 6 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

This QUIC change includes: 1) Change QuicStream's life time. QuicStream is not deletable when it has unacked data (including FIN). 2) Closed but not deletable QuicStream is moved to zombie_streams in QuicSession. 3) Move ack listener to QuicStream. 4) QuicHeaderStream keeps track of unacked headers which have not null ack listener. 5) Both QuicStream and QuicSession implement StreamNotifier which will be notified when stream frame is acked or retransmitted. Protected by FLAGS_quic_reloadable_flag_quic_use_stream_notifier. Merge internal change: 156886444 R=rch@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+653 lines, -9 lines) Patch
M net/quic/core/quic_connection.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/core/quic_connection.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M net/quic/core/quic_flags_list.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/core/quic_headers_stream.h View 2 chunks +40 lines, -0 lines 0 comments Download
M net/quic/core/quic_headers_stream.cc View 2 chunks +105 lines, -0 lines 0 comments Download
M net/quic/core/quic_headers_stream_test.cc View 2 chunks +60 lines, -1 line 0 comments Download
M net/quic/core/quic_sent_packet_manager.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/core/quic_sent_packet_manager.cc View 3 chunks +8 lines, -0 lines 0 comments Download
M net/quic/core/quic_session.h View 10 chunks +29 lines, -1 line 0 comments Download
M net/quic/core/quic_session.cc View 5 chunks +65 lines, -2 lines 0 comments Download
M net/quic/core/quic_session_test.cc View 3 chunks +20 lines, -0 lines 0 comments Download
M net/quic/core/quic_spdy_session.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/core/quic_spdy_stream_test.cc View 2 chunks +44 lines, -0 lines 0 comments Download
M net/quic/core/quic_stream.h View 9 chunks +32 lines, -2 lines 0 comments Download
M net/quic/core/quic_stream.cc View 6 chunks +60 lines, -2 lines 0 comments Download
M net/quic/core/quic_stream_test.cc View 2 chunks +98 lines, -0 lines 0 comments Download
M net/quic/core/quic_unacked_packet_map.h View 4 chunks +11 lines, -0 lines 0 comments Download
M net/quic/core/quic_unacked_packet_map.cc View 3 chunks +28 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_session_peer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_session_peer.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 chunk +21 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
Jana
3 years, 6 months ago (2017-06-01 01:46:42 UTC) #1
Ryan Hamilton
Any idea why all the bots are red?
3 years, 6 months ago (2017-06-01 16:51:23 UTC) #6
Jana
On 2017/06/01 16:51:23, Ryan Hamilton wrote: > Any idea why all the bots are red? ...
3 years, 6 months ago (2017-06-02 00:09:12 UTC) #7
Ryan Hamilton
3 years, 6 months ago (2017-06-02 00:18:51 UTC) #8
lgtm

Powered by Google App Engine
This is Rietveld 408576698