Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 2921603002: Inline methods of QuicBandwidth class. No functional change; not (Closed)

Created:
3 years, 6 months ago by Jana
Modified:
3 years, 6 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Inline methods of QuicBandwidth class. No functional change; not flag-protected. Since "B" in "BBR" stands for bandwidth, we've been using QuicBandwidth class much more actively on the hot paths. The overhead from calling QuicBandwidth methods started to show up on profiles, so I've maked a CL to make them all inlined, as it was done with QuicTime::Delta. This removes the non-negativity check from the QuicBandwidth constructor where it would previously result in a QUIC_BUG, since it's now constexpr. Merge internal change: 156806926 R=rch@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -117 lines) Patch
M net/quic/core/quic_bandwidth.h View 2 chunks +47 lines, -17 lines 0 comments Download
M net/quic/core/quic_bandwidth.cc View 1 chunk +0 lines, -100 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 2 (0 generated)
Jana
3 years, 6 months ago (2017-06-01 06:37:27 UTC) #1
Ryan Hamilton
3 years, 6 months ago (2017-06-01 15:21:53 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698