Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2915993002: Move tests from portable_quic to the new quic/quartc wrapper location. (Closed)

Created:
3 years, 6 months ago by Jana
Modified:
3 years, 6 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move tests from portable_quic to the new quic/quartc wrapper location. n/a (test only, tests code that is only linked by Quartc) Merge internal change: 156794055 R=rch@chromium.org BUG=

Patch Set 1 #

Patch Set 2 : Added missing test files and included in BUILD.gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+949 lines, -15 lines) Patch
M net/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/quartc/quartc_session.h View 1 chunk +5 lines, -1 line 0 comments Download
M net/quic/quartc/quartc_session.cc View 2 chunks +25 lines, -14 lines 0 comments Download
A net/quic/quartc/quartc_session_test.cc View 1 1 chunk +641 lines, -0 lines 0 comments Download
A net/quic/quartc/quartc_stream_test.cc View 1 1 chunk +276 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (0 generated)
Jana
3 years, 6 months ago (2017-06-01 00:53:59 UTC) #1
Ryan Hamilton
I don't see any tests affected by this CL. Are all of the tests already ...
3 years, 6 months ago (2017-06-01 02:09:28 UTC) #2
Jana
On 2017/06/01 02:09:28, Ryan Hamilton wrote: > I don't see any tests affected by this ...
3 years, 6 months ago (2017-06-01 23:22:18 UTC) #3
Ryan Hamilton
On 2017/06/01 23:22:18, Jana wrote: > On 2017/06/01 02:09:28, Ryan Hamilton wrote: > > I ...
3 years, 6 months ago (2017-06-01 23:25:36 UTC) #4
Jana
On 2017/06/01 23:25:36, Ryan Hamilton wrote: > On 2017/06/01 23:22:18, Jana wrote: > > On ...
3 years, 6 months ago (2017-06-01 23:29:32 UTC) #5
Ryan Hamilton
3 years, 6 months ago (2017-06-01 23:31:49 UTC) #6
On 2017/06/01 23:29:32, Jana wrote:
> On 2017/06/01 23:25:36, Ryan Hamilton wrote:
> > On 2017/06/01 23:22:18, Jana wrote:
> > > On 2017/06/01 02:09:28, Ryan Hamilton wrote:
> > > > I don't see any tests affected by this CL. Are all of the tests already
> here
> > > in
> > > > chromium and in the build files? (And are they the same version as
> > internal?)
> > > 
> > > Sorry I missed them. I've added them in the final landing CL now, and
added
> > them
> > > to BUILD.gn. Do you want me to add them to this CL as well?
> > 
> > That's fine. Thanks.
> > 
> > lgtm
> 
> Added them anyways, for posterity.

Even better! LGTM

Powered by Google App Engine
This is Rietveld 408576698