mb: Enable dcheck_always_on for Clang(ToT)Win shared release bots

mb: Enable dcheck_always_on for Clang(ToT)Win release bots

This would have caught the recent dcheck we hit in mksnapshot (see bug) and
gives us more coverage in general.

BUG=726896
R=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2915633002 .
Cr-Commit-Position: refs/heads/master@{#475683}
Committed: https://chromium.googlesource.com/chromium/src/+/51f8742b06870bb6e3b79ca3dca2663dbb7c4131

[hans, 2017-05-30 18:40:59]

hans@chromium.org changed reviewers:
+ thakis@chromium.org

[hans, 2017-05-30 18:41:00]

What do you think?

[Nico, 2017-05-30 19:56:18]

I'm not opposed to a release+dcheck bot, but I think our is_official_build=true
bots shouldn't have dchecks on.

https://codereview.chromium.org/2915633002/diff/1/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (right):

https://codereview.chromium.org/2915633002/diff/1/tools/mb/mb_config.pyl#newc...
tools/mb/mb_config.pyl:139: 'CrWinClang':
'clang_official_release_bot_minimal_symbols_x86_dcheck',
CrWinClang does official builds. We have no other bots that do official +
dcheck, so this one shouldn't either.

[hans, 2017-05-30 19:58:01]

That's a good point. What do you think about using our shared builders for this?
I don't think they do official builds.

It wouldn't exactly match the config of trybot, but I don't think it should
matter.. (famous last words I suppose).

[Nico, 2017-05-30 20:05:45]

Sounds like that's worth trying :-)

On Tue, May 30, 2017 at 3:58 PM, <hans@chromium.org> wrote:

> That's a good point. What do you think about using our shared builders for
> this?
> I don't think they do official builds.
>
> It wouldn't exactly match the config of trybot, but I don't think it should
> matter.. (famous last words I suppose).
>
> https://codereview.chromium.org/2915633002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[hans, 2017-05-30 20:22:06]

Description was changed from

==========
mb: Enable dcheck_always_on for Clang(ToT)Win release bots

This would have caught the recent dcheck we hit in mksnapshot (see bug) and
gives us more coverage in general.

BUG=726896
==========

to

==========
mb: Enable dcheck_always_on for Clang(ToT)Win release bots

This would have caught the recent dcheck we hit in mksnapshot (see bug) and
gives us more coverage in general.

BUG=726896
==========

[hans, 2017-05-30 20:22:19]

Please take another look.

[Nico, 2017-05-30 20:29:25]

lgtm, thanks!

https://codereview.chromium.org/2915633002/diff/20001/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (right):

https://codereview.chromium.org/2915633002/diff/20001/tools/mb/mb_config.pyl#...
tools/mb/mb_config.pyl:176: 'CrWinClangLLD64':
'clang_tot_shared_release_use_lld',
possibly this one too

[hans, 2017-05-30 20:33:04]

https://codereview.chromium.org/2915633002/diff/20001/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (right):

https://codereview.chromium.org/2915633002/diff/20001/tools/mb/mb_config.pyl#...
tools/mb/mb_config.pyl:176: 'CrWinClangLLD64':
'clang_tot_shared_release_use_lld',
On 2017/05/30 20:29:24, Nico wrote:
> possibly this one too

Done.

[hans, 2017-05-30 20:33:08]

The CQ bit was checked by hans@chromium.org

[hans, 2017-05-30 20:33:09]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2915633002/#ps40001
(title: "CrWinClangLLD64 too")

[commit-bot: I haz the power, 2017-05-30 20:33:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hans, 2017-05-30 21:59:01]

Description was changed from

==========
mb: Enable dcheck_always_on for Clang(ToT)Win release bots

This would have caught the recent dcheck we hit in mksnapshot (see bug) and
gives us more coverage in general.

BUG=726896
==========

to

==========
mb: Enable dcheck_always_on for Clang(ToT)Win release bots

This would have caught the recent dcheck we hit in mksnapshot (see bug) and
gives us more coverage in general.

BUG=726896
R=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2915633002 .
Cr-Commit-Position: refs/heads/master@{#475683}
Committed:
https://chromium.googlesource.com/chromium/src/+/51f8742b06870bb6e3b79ca3dca2...
==========

[hans, 2017-05-30 21:59:02]

Committed patchset #3 (id:40001) manually as
51f8742b06870bb6e3b79ca3dca2663dbb7c4131 (presubmit successful).