mb: Enable dcheck_always_on for Clang(ToT)Win shared release bots

tools/mb/mb_config.pyl

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This is a .pyl, or "Python Literal", file. You can treat it just like a
 # .json file, with the following exceptions:
 # * all keys must be quoted (use single quotes, please);
 # * comments are allowed, using '#' syntax; and
 # * trailing commas are allowed.
 
@@ skipping 118 matching lines @@
         '1': 'official_optimize_chrome_pgo_phase_1',
         '2': 'official_optimize_chrome_pgo_phase_2',
       },
       'Chromium Windows Analyze': 'windows_analyze',
       'CrWin7Goma': 'release_bot_x86',
       'CrWin7Goma(clbr)': 'shared_release_bot_x86',
       'CrWin7Goma(dbg)': 'debug_bot_x86',
       'CrWin7Goma(dll)': 'shared_release_bot_x86',
 
       # if CrWinClang is modified, please update CrWinClangGoma in the same way.
-      'CrWinClang': 'clang_official_release_bot_minimal_symbols_x86',
+      'CrWinClang': 'clang_official_release_bot_minimal_symbols_x86_dcheck',

[Nico, 2017/05/30 19:56:18]

CrWinClang does official builds. We have no other bots that do official +
dcheck, so this one shouldn't either.

 
       'CrWinClang(dbg)': 'clang_debug_bot_minimal_symbols_x86',
-      'CrWinClang64': 'clang_official_release_bot_minimal_symbols',
+      'CrWinClang64': 'clang_official_release_bot_minimal_symbols_dcheck',
       'CrWinClang64(dll)': 'clang_shared_release_bot',
-      'CrWinClangGoma': 'clang_official_optimize_release_bot_minimal_symbols_x86',
+      'CrWinClangGoma': 'clang_official_optimize_release_bot_minimal_symbols_x86_dcheck',
       'CrWinGoma': 'release_bot_x86',
       'CrWinGoma(dll)': 'shared_release_bot_x86',
       'CrWinGoma(loc)': 'shared_release_bot_x86',
       'ClangToTAndroidASan': 'android_clang_tot_asan',
       'ClangToTAndroid (dbg)': 'android_clang_tot_dbg',
       'ClangToTAndroid': 'android_clang_tot_release',
       'ClangToTAndroid64': 'android_clang_tot_release_arm64',
       'ClangToTAndroid x64': 'android_clang_tot_x64',
       'ClangToTLinux': 'clang_tot_linux_full_symbols_shared_release',
       'ClangToTLinux (dbg)': 'clang_tot_shared_debug',
       'ClangToTLinuxASan': 'clang_tot_asan_lsan_static_release',
       'ClangToTLinuxASanLibfuzzer': 'release_libfuzzer_asan_clang_tot',
       'ClangToTLinuxLLD': 'clang_tot_lld_release_shared',
       'ClangToTLinuxUBSanVptr': 'clang_tot_edge_ubsan_no_recover_hack_static_release',
       'ClangToTMac': 'clang_tot_minimal_symbols_shared_release',
       'ClangToTMac (dbg)': 'clang_tot_shared_debug',
       'ClangToTMacASan': 'asan_disable_nacl_clang_tot_full_symbols_static_release',
-      'ClangToTWin': 'clang_tot_official_minimal_symbols_static_release_x86',
+      'ClangToTWin': 'clang_tot_official_minimal_symbols_static_release_x86_dcheck',
       'ClangToTWin(dbg)': 'clang_tot_shared_debug_x86',
       'ClangToTWin(dll)': 'clang_tot_minimal_symbols_shared_release_x86',
-      'ClangToTWin64': 'clang_tot_official_minimal_symbols_static_release',
+      'ClangToTWin64': 'clang_tot_official_minimal_symbols_static_release_dcheck',
       'ClangToTWin64(dbg)': 'clang_tot_shared_debug',
       'ClangToTWin64(dll)': 'clang_tot_shared_release',
       'ClangToTiOS': 'ios',
       'Closure Compilation Linux': 'closure_compilation',
       'CrWinAsan': 'asan_clang_fuzzer_static_v8_heap_x86_full_symbols_release',
       'CrWinAsan(dll)': 'asan_clang_shared_v8_heap_x86_full_symbols_release',
       'CrWinAsanCov': 'asan_clang_edge_fuzzer_static_v8_heap_x86_full_symbols_release',
       'CrWinClang(shared)': 'clang_minimal_symbols_shared_release_bot_x86',
       'CrWinClang64(dbg)': 'win_clang_debug_bot',
       'CrWinClangLLD': 'clang_tot_official_static_use_lld_x86',
@@ skipping 868 matching lines @@
     ],
 
     'clang_release_bot_minimal_symbols_x86': [
       'clang', 'release_bot', 'minimal_symbols', 'x86',
     ],
 
     'clang_minimal_symbols_shared_release_bot_x86': [
       'clang', 'minimal_symbols', 'shared_release_bot', 'x86',
     ],
 
-    'clang_official_release_bot_minimal_symbols': [
-      'clang', 'official', 'release_bot', 'minimal_symbols',
+    'clang_official_release_bot_minimal_symbols_dcheck': [
+      'clang', 'official', 'release_bot', 'minimal_symbols', 'dcheck_always_on',
     ],
 
-    'clang_official_release_bot_minimal_symbols_x86': [
-      'clang', 'official', 'release_bot', 'minimal_symbols', 'x86',
+    'clang_official_release_bot_minimal_symbols_x86_dcheck': [
+      'clang', 'official', 'release_bot', 'minimal_symbols', 'x86', 'dcheck_always_on',
     ],
 
-    'clang_official_optimize_release_bot_minimal_symbols_x86': [
-      'clang', 'official_optimize', 'release_bot', 'minimal_symbols', 'x86',
+    'clang_official_optimize_release_bot_minimal_symbols_x86_dcheck': [
+      'clang', 'official_optimize', 'release_bot', 'minimal_symbols', 'x86', 'dcheck_always_on',
     ],
 
     'clang_official_release_trybot': [
       'clang', 'official', 'release_trybot',
     ],
 
     'clang_official_release_trybot_x86': [
       'clang', 'official', 'release_trybot', 'x86',
     ],
 
@@ skipping 46 matching lines @@
     ],
 
     'clang_tot_shared_release': [
       'clang_tot', 'shared', 'release',
     ],
 
     'clang_tot_minimal_symbols_shared_release_x86': [
       'clang_tot', 'minimal_symbols', 'shared', 'release', 'x86',
     ],
 
-    'clang_tot_official_minimal_symbols_static_release': [
-      'clang_tot', 'official', 'minimal_symbols', 'static', 'release',
+    'clang_tot_official_minimal_symbols_static_release_dcheck': [
+      'clang_tot', 'official', 'minimal_symbols', 'static', 'release', 'dcheck_always_on',
     ],
 
-    'clang_tot_official_minimal_symbols_static_release_x86': [
-      'clang_tot', 'official', 'minimal_symbols', 'static', 'release', 'x86',
+    'clang_tot_official_minimal_symbols_static_release_x86_dcheck': [
+      'clang_tot', 'official', 'minimal_symbols', 'static', 'release', 'x86', 'dcheck_always_on',
     ],
 
     'clang_tot_lld_release_shared': [
       # TODO(crbug.com/605819): Enable debug info in release builds.
       'clang_tot', 'release', 'shared', 'use_lld',
     ],
 
     'clang_tot_shared_debug': [
       'clang_tot', 'shared', 'debug',
     ],
@@ skipping 743 matching lines @@
 
     'x64': {
       'gn_args': 'target_cpu="x64"',
     },
 
     'x86': {
       'gn_args': 'target_cpu="x86"',
     },
   },
 }