Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issue 2915623002: Permanently turn on auto-dismissing dialogs. (Closed)

Created:
3 years, 6 months ago by Avi (use Gerrit)
Modified:
3 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Permanently turn on auto-dismissing dialogs. BUG=629964, 629324 Review-Url: https://codereview.chromium.org/2915623002 Cr-Commit-Position: refs/heads/master@{#476000} Committed: https://chromium.googlesource.com/chromium/src/+/a7e95918de8e2e63e460132f21070ac82a6140db

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -90 lines) Patch
M chrome/browser/ui/javascript_dialogs/javascript_dialog_browsertest.cc View 4 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc View 3 chunks +58 lines, -69 lines 0 comments Download
M chrome/common/chrome_features.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/chrome_features.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Avi (use Gerrit)
Whoo!
3 years, 6 months ago (2017-05-30 20:48:56 UTC) #6
Avi (use Gerrit)
ping
3 years, 6 months ago (2017-05-31 15:25:29 UTC) #7
Nico
lgtm
3 years, 6 months ago (2017-05-31 16:11:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2915623002/1
3 years, 6 months ago (2017-05-31 17:23:26 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 20:25:49 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a7e95918de8e2e63e460132f2107...

Powered by Google App Engine
This is Rietveld 408576698