Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3462)

Unified Diff: chrome/browser/ui/javascript_dialogs/javascript_dialog_browsertest.cc

Issue 2915623002: Permanently turn on auto-dismissing dialogs. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/javascript_dialogs/javascript_dialog_browsertest.cc
diff --git a/chrome/browser/ui/javascript_dialogs/javascript_dialog_browsertest.cc b/chrome/browser/ui/javascript_dialogs/javascript_dialog_browsertest.cc
index 73a3549cfb596bc9e8038b640d99cff8c15138c7..a84ba449e5de59a699d41fda9445ae069098b765 100644
--- a/chrome/browser/ui/javascript_dialogs/javascript_dialog_browsertest.cc
+++ b/chrome/browser/ui/javascript_dialogs/javascript_dialog_browsertest.cc
@@ -5,11 +5,9 @@
#include "base/logging.h"
#include "base/strings/utf_string_conversions.h"
#include "base/test/scoped_command_line.h"
-#include "base/test/scoped_feature_list.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
-#include "chrome/common/chrome_features.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "content/public/browser/render_frame_host.h"
@@ -20,9 +18,6 @@
using JavaScriptDialogTest = InProcessBrowserTest;
IN_PROC_BROWSER_TEST_F(JavaScriptDialogTest, ReloadDoesntHang) {
- base::test::ScopedFeatureList feature_list;
- feature_list.InitAndEnableFeature(features::kAutoDismissingDialogs);
-
content::WebContents* tab =
browser()->tab_strip_model()->GetActiveWebContents();
JavaScriptDialogTabHelper* js_helper =
@@ -44,9 +39,6 @@ IN_PROC_BROWSER_TEST_F(JavaScriptDialogTest, ReloadDoesntHang) {
IN_PROC_BROWSER_TEST_F(JavaScriptDialogTest,
ClosingPageSharingRendererDoesntHang) {
- base::test::ScopedFeatureList feature_list;
- feature_list.InitAndEnableFeature(features::kAutoDismissingDialogs);
-
// Turn off popup blocking.
base::test::ScopedCommandLine scoped_command_line;
scoped_command_line.GetProcessCommandLine()->AppendSwitch(
@@ -85,9 +77,6 @@ IN_PROC_BROWSER_TEST_F(JavaScriptDialogTest,
IN_PROC_BROWSER_TEST_F(JavaScriptDialogTest,
ClosingPageWithSubframeAlertingDoesntCrash) {
- base::test::ScopedFeatureList feature_list;
- feature_list.InitAndEnableFeature(features::kAutoDismissingDialogs);
-
content::WebContents* tab =
browser()->tab_strip_model()->GetActiveWebContents();
JavaScriptDialogTabHelper* js_helper =
« no previous file with comments | « no previous file | chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698