Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 2915483003: Remove MojoCompositorFrameSink::EvictCurrentSurface (Closed)

Created:
3 years, 6 months ago by Fady Samuel
Modified:
3 years, 6 months ago
Reviewers:
Tom Sepez, piman
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, cc-bugs_chromium.org, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove MojoCompositorFrameSink::EvictCurrentSurface This API isn't used anywhere so this CL deletes some dead code. BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2915483003 Cr-Commit-Position: refs/heads/master@{#475697} Committed: https://chromium.googlesource.com/chromium/src/+/2da93ede2753388669627579529beaa1c03548f5

Patch Set 1 #

Patch Set 2 : Fix FrameGenerator unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -23 lines) Patch
M cc/ipc/mojo_compositor_frame_sink.mojom View 1 chunk +0 lines, -4 lines 0 comments Download
M components/viz/frame_sinks/gpu_compositor_frame_sink.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/viz/frame_sinks/gpu_compositor_frame_sink.cc View 1 chunk +1 line, -5 lines 0 comments Download
M components/viz/frame_sinks/gpu_root_compositor_frame_sink.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/viz/frame_sinks/gpu_root_compositor_frame_sink.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/ws/compositor_frame_sink_client_binding.h View 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/ws/compositor_frame_sink_client_binding.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M services/ui/ws/frame_generator_unittest.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (16 generated)
Fady Samuel
+tsepez@ for mojom +piman@ for the rest.
3 years, 6 months ago (2017-05-30 19:25:42 UTC) #3
piman
lgtm
3 years, 6 months ago (2017-05-30 19:37:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2915483003/1
3 years, 6 months ago (2017-05-30 19:50:54 UTC) #12
Tom Sepez
lgtm
3 years, 6 months ago (2017-05-30 20:08:45 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/437686)
3 years, 6 months ago (2017-05-30 20:25:43 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2915483003/20001
3 years, 6 months ago (2017-05-30 20:35:04 UTC) #20
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 23:53:54 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2da93ede2753388669627579529b...

Powered by Google App Engine
This is Rietveld 408576698