Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2915233002:
DevTools: jsdoc for showToolbarPane in Elements (Closed)
|
Created:
3 years, 6 months ago by luoe Modified:
3 years, 6 months ago CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: jsdoc for showToolbarPane in Elements
This is part of an effort to migrate SSP to shadow DOM as its own component.
BUG=None
Review-Url: https://codereview.chromium.org/2915233002
Cr-Commit-Position: refs/heads/master@{#477187}
Committed: https://chromium.googlesource.com/chromium/src/+/a91ddbd742e1c7aaf65dff31a1aaf4b1a95f68d4
Patch Set 1 : a #
Total comments: 4
Patch Set 2 : ac #
Dependent Patchsets: Messages
Total messages: 18 (10 generated)
Patchset #1 (id:1) has been deleted
Description was changed from ========== DevTools: jsdoc for showToolbarPane in Elements BUG=None ========== to ========== DevTools: jsdoc for showToolbarPane in Elements This is part of an effort to migrate SSP to shadow DOM as its own component. BUG=None ==========
luoe@chromium.org changed reviewers: + einbinder@chromium.org
Please take a look
lgtm https://codereview.chromium.org/2915233002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js (right): https://codereview.chromium.org/2915233002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js:34: * @unrestricted Remove unrestricted. https://codereview.chromium.org/2915233002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js:78: this._pendingWidgetToggle; = null
luoe@chromium.org changed reviewers: + dgozman@chromium.org
Ptal https://codereview.chromium.org/2915233002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js (right): https://codereview.chromium.org/2915233002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js:34: * @unrestricted On 2017/06/03 01:52:44, einbinder wrote: > Remove unrestricted. Sorry, my CL title was misleading. I'm not adding jsdoc for the entire ElementsPanel, just a few members that I planned to move in the next CL. I didn't want to do it in the other CL only because it was getting large and I wanted to split this to be easier to review. https://codereview.chromium.org/2915233002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js:78: this._pendingWidgetToggle; On 2017/06/03 01:52:44, einbinder wrote: > = null Done.
lgtm
The CQ bit was checked by luoe@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from einbinder@chromium.org Link to the patchset: https://codereview.chromium.org/2915233002/#ps40001 (title: "ac")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by luoe@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496717822672140,
"parent_rev": "0edfa5663e5a6fadb4bf656e9ac057527bd8b3f4", "commit_rev":
"a91ddbd742e1c7aaf65dff31a1aaf4b1a95f68d4"}
Message was sent while issue was closed.
Description was changed from ========== DevTools: jsdoc for showToolbarPane in Elements This is part of an effort to migrate SSP to shadow DOM as its own component. BUG=None ========== to ========== DevTools: jsdoc for showToolbarPane in Elements This is part of an effort to migrate SSP to shadow DOM as its own component. BUG=None Review-Url: https://codereview.chromium.org/2915233002 Cr-Commit-Position: refs/heads/master@{#477187} Committed: https://chromium.googlesource.com/chromium/src/+/a91ddbd742e1c7aaf65dff31a1aa... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/a91ddbd742e1c7aaf65dff31a1aa... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
