Issue 2915163002: Stops accumulating performance statistics on the Chrome App.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2915163002: Stops accumulating performance statistics on the Chrome App. (Closed)

Created:
3 years, 6 months ago by kelvinp

Modified:
3 years, 6 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3112

Project:
chromium

Visibility:
Public.

Stops accumulating performance statistics on the Chrome App. This CL also fixes a BUILD file error so that JSCompiler can be run. BUG=727904 Review-Url: https://codereview.chromium.org/2913073002 Cr-Original-Commit-Position: refs/heads/master@{#475753} Review-Url: https://codereview.chromium.org/2915163002 . Cr-Commit-Position: refs/branch-heads/3112@{#100} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/babc3f453986724dcdbc1e4c3c7ffab9c087455a

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+72 lines, -290 lines)			Patch
M	remoting/webapp/base/js/client_plugin_impl.js	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	remoting/webapp/base/js/client_session.js	View	2 chunks	+15 lines, -1 line	0 comments	Download
M	remoting/webapp/base/js/session_logger.js	View	7 chunks	+28 lines, -56 lines	0 comments	Download
M	remoting/webapp/base/js/session_logger_unittest.js	View	3 chunks	+22 lines, -45 lines	0 comments	Download
D	remoting/webapp/base/js/stats_accumulator.js	View	1 chunk	+0 lines, -186 lines	0 comments	Download
M	remoting/webapp/build_template.gni	View	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/webapp/files.gni	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 2 (1 generated)

kelvinp

3 years, 6 months ago (2017-06-01 18:28:59 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
babc3f453986724dcdbc1e4c3c7ffab9c087455a.