Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1001)

Issue 2913073002: Stops accumulating performance statistics on the Chrome App. (Closed)

Created:
3 years, 6 months ago by kelvinp
Modified:
3 years, 6 months ago
Reviewers:
Sergey Ulanov, Yuwei
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Stops accumulating performance statistics on the Chrome App. This CL also fixes a BUILD file error so that JSCompiler can be run. BUG=727904 Review-Url: https://codereview.chromium.org/2913073002 Cr-Commit-Position: refs/heads/master@{#475753} Committed: https://chromium.googlesource.com/chromium/src/+/46b223971e06d096ad658560d13b48a4f3c5eb41

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -290 lines) Patch
M remoting/webapp/base/js/client_plugin_impl.js View 1 chunk +6 lines, -0 lines 0 comments Download
M remoting/webapp/base/js/client_session.js View 2 chunks +15 lines, -1 line 0 comments Download
M remoting/webapp/base/js/session_logger.js View 7 chunks +28 lines, -56 lines 0 comments Download
M remoting/webapp/base/js/session_logger_unittest.js View 3 chunks +22 lines, -45 lines 0 comments Download
D remoting/webapp/base/js/stats_accumulator.js View 1 chunk +0 lines, -186 lines 0 comments Download
M remoting/webapp/build_template.gni View 1 chunk +1 line, -1 line 0 comments Download
M remoting/webapp/files.gni View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
kelvinp
PTAL
3 years, 6 months ago (2017-05-30 21:51:59 UTC) #3
Sergey Ulanov
lgtm
3 years, 6 months ago (2017-05-30 22:30:14 UTC) #4
Yuwei
LGTM
3 years, 6 months ago (2017-05-31 00:37:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2913073002/1
3 years, 6 months ago (2017-05-31 00:48:18 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 02:33:37 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/46b223971e06d096ad658560d13b...

Powered by Google App Engine
This is Rietveld 408576698